This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] - Don't crash when a broken GNU hash table is dumped with --hash-symbols.
ClosedPublic

Authored by grimar on Jun 24 2020, 3:53 AM.

Details

Summary

Start using the checkGNUHashTable helper which was recently introduced to report
a proper warning when a GNU hash table goes past the end of the file.

Diff Detail

Event Timeline

grimar created this revision.Jun 24 2020, 3:53 AM
Herald added a project: Restricted Project. · View Herald Transcript
jhenderson accepted this revision.Jun 24 2020, 4:42 AM

LGTM, with nit.

llvm/tools/llvm-readobj/ELFDumper.cpp
4072

I'd change "printing" to "printing the" if you are making the other change.

This revision is now accepted and ready to land.Jun 24 2020, 4:42 AM
This revision was automatically updated to reflect the committed changes.