Page MenuHomePhabricator

[clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`
ClosedPublic

Authored by arphaman on Jun 23 2020, 7:00 PM.

Diff Detail

Event Timeline

arphaman created this revision.Jun 23 2020, 7:00 PM
steven_wu accepted this revision.Jun 23 2020, 7:13 PM

LGTM.

Not sure if it makes more sense to break the patch into two commits:

  • config.guess change is for building the correct host triple on apple silicon machine without explicitly specify it.
  • the driver change is for better default on Apple silicon Mac.
This revision is now accepted and ready to land.Jun 23 2020, 7:13 PM

LGTM.

Not sure if it makes more sense to break the patch into two commits:

  • config.guess change is for building the correct host triple on apple silicon machine without explicitly specify it.
  • the driver change is for better default on Apple silicon Mac.

That's a good idea, I will do that.

This revision was automatically updated to reflect the committed changes.