Details
Details
- Reviewers
c-rhodes fpetrogalli kmclaughlin
Diff Detail
Diff Detail
Event Timeline
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_bfdot.c | ||
---|---|---|
3–6 | I don't think there's any value in testing this for each ACLE test adding bfloat support, see my comment here: https://reviews.llvm.org/D82182#2108831 There's value in checking that specific intrinsics are guarded by __ARM_FEATURE_SVE_BF16 (which will eventually be implied by +bf16), but I suspect we could create a single test for what you've added here that just includes arm_sve.h. |
I don't think there's any value in testing this for each ACLE test adding bfloat support, see my comment here: https://reviews.llvm.org/D82182#2108831
There's value in checking that specific intrinsics are guarded by __ARM_FEATURE_SVE_BF16 (which will eventually be implied by +bf16), but I suspect we could create a single test for what you've added here that just includes arm_sve.h.