This is an archive of the discontinued LLVM Phabricator instance.

[SveEmitter] Add verify-checks to Clang bfloat16 tests
AbandonedPublic

Authored by sdesmalen on Jun 23 2020, 4:59 AM.

Diff Detail

Event Timeline

sdesmalen created this revision.Jun 23 2020, 4:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2020, 4:59 AM
Herald added a subscriber: tschuett. · View Herald Transcript
c-rhodes added inline comments.Jun 23 2020, 5:39 AM
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_bfdot.c
3–6

I don't think there's any value in testing this for each ACLE test adding bfloat support, see my comment here: https://reviews.llvm.org/D82182#2108831

There's value in checking that specific intrinsics are guarded by __ARM_FEATURE_SVE_BF16 (which will eventually be implied by +bf16), but I suspect we could create a single test for what you've added here that just includes arm_sve.h.

sdesmalen abandoned this revision.Jul 1 2020, 8:45 AM