This is an archive of the discontinued LLVM Phabricator instance.

[Coroutines] Fix a few failing tests
ClosedPublic

Authored by lxfind on Jun 22 2020, 5:58 PM.

Details

Reviewers
lewissbaker
modocache
ldionne
Group Reviewers
Restricted Project
Commits
rGf2dd08844c1a: [Coroutines] Fix a few failing tests
Summary

https://reviews.llvm.org/D82029 introduced the non-throw check for final_suspend(). There are a few tests I missed in that patch.
Fixing them here.

Diff Detail

Event Timeline

lxfind created this revision.Jun 22 2020, 5:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2020, 5:58 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
lxfind requested review of this revision.Jun 22 2020, 6:02 PM
lxfind added reviewers: lewissbaker, modocache.
lxfind updated this revision to Diff 272588.Jun 22 2020, 7:29 PM

Address lint message

ChuanqiXu removed a subscriber: ChuanqiXu.
ldionne accepted this revision.Jun 23 2020, 6:09 AM
This revision is now accepted and ready to land.Jun 23 2020, 6:09 AM
lxfind updated this revision to Diff 272772.Jun 23 2020, 10:47 AM

Rebase. Fix two more tests.

This revision was automatically updated to reflect the committed changes.