[AIX] [test-suite] Enable standard compatable mode on AIX

[stevewan]

Summary

Since the current default _ALL_SOURCE causes numerous issues on AIX (e.g., typedef redefinition, unintended macro expansion), this patch changes the configuration to use standard-compatable mode by appending XOPEN_SOURCE=700. This flag is added to cflags for all the C test cases because a considerable number of C tests are affected by the _ALL_SOURCE problem. For one particular C++ test case that was also affected by _ALL_SOURCE, the flag is appended to the cxxflags in its sub-level CMakeLists.

[daltenty]

LGTM other than minor nit

CMakeLists.txt

173

nit: I think we should probably add a comment that this is a work around for system header issues that we are intending to apply only to C, something like:

# Use X/OPEN compatibility flag on AIX for C tests to avoid problems with some versions of the system headers.

[stevewan]

Add comment based on review.

[stevewan]

Committed in https://github.com/llvm/llvm-test-suite/commit/000c7b8d78b12b5cc70ad4e69a4cdb1bab23f74d.

[azhar]

This is failing on Darwin. Looks like for the C++ test too, the flag should be added only if it is AIX.

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/mytimer.cpp:116:19: error: variable has incomplete type 'struct timezone'

Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7783/consoleFull.

[stevewan]

In D82321#2134054, @azhar wrote:

This is failing on Darwin. Looks like for the C++ test too, the flag should be added only if it is AIX.

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/mytimer.cpp:116:19: error: variable has incomplete type 'struct timezone'

Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7783/consoleFull.

Thanks for the note, I'm looking into this.

[stevewan]

In D82321#2134054, @azhar wrote:

This is failing on Darwin. Looks like for the C++ test too, the flag should be added only if it is AIX.

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/mytimer.cpp:116:19: error: variable has incomplete type 'struct timezone'

Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7783/consoleFull.

Reverted the C++ part.

[stevewan]

In D82321#2134054, @azhar wrote:

This is failing on Darwin. Looks like for the C++ test too, the flag should be added only if it is AIX.

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/mytimer.cpp:116:19: error: variable has incomplete type 'struct timezone'

Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7783/consoleFull.

The reported failure is fixed in the latest build, http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7867/consoleFull.

[azhar]

In D82321#2134267, @stevewan wrote:

In D82321#2134054, @azhar wrote:

This is failing on Darwin. Looks like for the C++ test too, the flag should be added only if it is AIX.

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/mytimer.cpp:116:19: error: variable has incomplete type 'struct timezone'

Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7783/consoleFull.

Reverted the C++ part.

Thanks @stevewan.

CMakeLists.txt

set(TEST_SUITE_EXTRA_EXE_LINKER_FLAGS CACHE STRING
     "Extra flags for CMAKE_EXE_LINKER_FLAGS")
 mark_as_advanced(TEST_SUITE_EXTRA_C_FLAGS, TEST_SUITE_EXTRA_CXX_FLAGS,
                  TEST_SUITE_EXTRA_EXE_LINKER_FLAGS)
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${TEST_SUITE_EXTRA_C_FLAGS}")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${TEST_SUITE_EXTRA_CXX_FLAGS}")
 set(CMAKE_EXE_LINKER_FLAGS
     "${CMAKE_EXE_LINKER_FLAGS} ${TEST_SUITE_EXTRA_EXE_LINKER_FLAGS}")
 
+# Use X/OPEN compatibility flag on AIX for C tests to avoid problems
+# with some versions of the system headers.
+if(CMAKE_SYSTEM_NAME STREQUAL "AIX")
+  set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -D_XOPEN_SOURCE=700")
+endif()
+
 # This is either directly the C++ ABI library or the full C++ library
 # which pulls in the ABI transitively.
 set(TEST_SUITE_CXX_ABI "default" CACHE STRING "Specify C++ ABI library to use.")
 set(CXXABIS "none default libstdc++ libsupc++ libc++ libc++abi")
 set_property(CACHE TEST_SUITE_CXX_ABI PROPERTY STRINGS "${CXXABIS}")
 if (TEST_SUITE_CXX_ABI STREQUAL "default")
   if (APPLE OR CMAKE_SYSTEM_NAME MATCHES "FreeBSD|Fuchsia")
     set(TEST_SUITE_CXX_ABI_LIBNAME "c++abi")

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/CMakeLists.txt

-list(APPEND CXXFLAGS -I. -DMINIFE_SCALAR=double  -DMINIFE_LOCAL_ORDINAL=int -DMINIFE_GLOBAL_ORDINAL=int -DMINIFE_CSR_MATRIX -DREDSTORM) # -DREDSTORM for mkdir
+list(APPEND CXXFLAGS -I. -DMINIFE_SCALAR=double  -DMINIFE_LOCAL_ORDINAL=int -DMINIFE_GLOBAL_ORDINAL=int -DMINIFE_CSR_MATRIX -DREDSTORM -D_XOPEN_SOURCE=700) # -DREDSTORM for mkdir
 list(APPEND LDFLAGS -lm)
 set(RUN_OPTIONS -nx 64 -ny 64 -nz 64)
 llvm_multisource(miniFE)
 target_include_directories(miniFE PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})