Page MenuHomePhabricator

A the `default_triple` feature to MLIR test suite
ClosedPublic

Authored by mehdi_amini on Jun 18 2020, 8:25 PM.

Details

Summary

This feature was added to LLVM in d178f4fc8 in order to be able to
run the LLVM tests without having the host targets configured in.
With this change, ninja check passes without the host target, i.e.
this config:

cmake ../llvm -DLLVM_TARGETS_TO_BUILD="" -DLLVM_DEFAULT_TARGET_TRIPLE="" -DLLVM_ENABLE_PROJECTS=mlir -GNinja

Diff Detail

Event Timeline

mehdi_amini created this revision.Jun 18 2020, 8:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2020, 8:25 PM
bondhugula accepted this revision.Jun 18 2020, 10:59 PM

Thanks for allowing this. I think the commit title's start is broken.

This revision is now accepted and ready to land.Jun 18 2020, 10:59 PM

Nit: I think the commit title doesn't accurately reflect empty target info.

mlir/test/mlir-cpu-runner/lit.local.cfg
7

Missing period at the end.

This revision was automatically updated to reflect the committed changes.