Page MenuHomePhabricator

Diagnostic message (error) related to ThinLTO caching needs to be downgraded to a remark
ClosedPublic

Authored by kromanova on Thu, Jun 18, 7:48 PM.

Details

Summary

This is a fix for PR #46392 (Diagnostic message (error) related to ThinLTO caching needs to be downgraded to a remark).

There are diagnostic messages related to ThinLTO caching that contain the word "error", but they are really just notices/remarks for users, and they don't cause a build failure. The word "error" appearing can be confusing to users, and may even cause deeper problems.

User's build system might be designed to interpret any error messages (even a benign error message as the one above) reported by the compiler as a build failure, thus causing the build to fail "needlessly". In short, the term "error" in this diagnostic is misleading at best, and may be causing build systems to fail at worst.

We would like to downgrade this "error" message to a diagnostic remark.

There is another error message that needs to be downgraded to a remark, since it’s benign too...

errs() << "error: can't reload cached file '" << CacheEntryPath
      << "': " << EC.message() << "\n";

Diff Detail

Event Timeline

kromanova created this revision.Thu, Jun 18, 7:48 PM
mehdi_amini accepted this revision.Thu, Jun 18, 8:46 PM
This revision is now accepted and ready to land.Thu, Jun 18, 8:46 PM
This revision was automatically updated to reflect the committed changes.