This is an archive of the discontinued LLVM Phabricator instance.

[AVR] Disassemble multiplication instructions
ClosedPublic

Authored by aykevl on Jun 16 2020, 2:50 PM.

Details

Summary

These can often only use a limited range of registers, and apparently need special decoding support.

Diff Detail

Event Timeline

aykevl created this revision.Jun 16 2020, 2:50 PM
dylanmckay requested changes to this revision.Jun 17 2020, 10:55 PM

Couple of nitpicks, otherwise good to go.

llvm/lib/Target/AVR/Disassembler/AVRDisassembler.cpp
173

Fit to 80 characters, prefer return on a new line

182

Same here re. 80 chars

This revision now requires changes to proceed.Jun 17 2020, 10:55 PM
aykevl updated this revision to Diff 271646.Jun 18 2020, 3:33 AM
  • fix formatting
dylanmckay accepted this revision.Jun 18 2020, 10:13 PM
This revision is now accepted and ready to land.Jun 18 2020, 10:13 PM
This revision was automatically updated to reflect the committed changes.