Page MenuHomePhabricator

[libc++] Add from-scratch configuration files for the test suite
ClosedPublic

Authored by ldionne on Jun 15 2020, 12:24 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGa711b5eeb0e5: [libc++] Add from-scratch configuration files for the test suite
Summary

This commit adds the first from-scratch configuration files for running
the libc++ test suite without using the old configuration:

  • libcxx-trunk-shared.cfg.py: Runs the test suite against a trunk libc++ shared library.
  • libcxx-trunk-static.cfg.py: Runs the test suite against a trunk libc++ static library.

Diff Detail

Event Timeline

ldionne created this revision.Jun 15 2020, 12:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2020, 12:24 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

This is a WIP example of how to specify custom config files for running the libc++ test suite. The intent is that such config files can be checked into the repository, representing how different vendors run the test suite. For example, it would make sense to me to have a configuration for running the test suite with MSVC's library or libstdc++.

For those wondering why I'm doing that:

  1. The more people we have running the test suite, the more people have an incentive to contribute to it and improve it, which means I get to do less of that and more of other stuff :-)
  2. Having different Lit config files is going to remove a lot of complexity from the CMake build, where we have crazy settings for things like "build the shared library but link the tests against the static library". This shouldn't be part of CMake, it should just be a matter of selecting the right testing configuration.
ldionne updated this revision to Diff 288802.Aug 29 2020, 1:26 PM

Remove the backdeployment config, which isn't quite ready yet.

ldionne accepted this revision as: Restricted Project.Aug 29 2020, 1:26 PM
ldionne edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2020, 1:54 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.