This is an archive of the discontinued LLVM Phabricator instance.

IRBuilder - add a CreateShuffleVector function that takes an ArrayRef of int
ClosedPublic

Authored by spatel on Mar 9 2015, 2:48 PM.

Details

Summary

Adding this convenience function was suggested in D8086 as a way to ease creation of ShuffleVectors in AutoUpgrade and other places.

I changed one instance in AutoUpgrade as an example of the intended usage.

Diff Detail

Event Timeline

spatel updated this revision to Diff 21516.Mar 9 2015, 2:48 PM
spatel retitled this revision from to IRBuilder - add a CreateShuffleVector function that takes an ArrayRef of int.
spatel updated this object.
spatel edited the test plan for this revision. (Show Details)
spatel added a subscriber: Unknown Object (MLST).
craig.topper edited edge metadata.Mar 10 2015, 9:51 PM

Patch looks fine to me other than my one comment. But I've never really looked at this file so I'm not sure I'm the best reviewer.

Patch looks fine to me other than my one comment. But I've never really looked at this file so I'm not sure I'm the best reviewer.

Thanks, Craig. Was that an inline comment? I'm not seeing anything posted here in the review.

andreadb accepted this revision.Mar 11 2015, 9:02 AM
andreadb edited edge metadata.

Hi Sanjay,

the patch looks good to me too.

This revision is now accepted and ready to land.Mar 11 2015, 9:02 AM
This revision was automatically updated to reflect the committed changes.

Yeah it was inline comment not sure why it disappeared. I just said to make the Idxs array in AutoUpgrade a 'const' array.

Yeah it was inline comment not sure why it disappeared. I just said to make the Idxs array in AutoUpgrade a 'const' array.

Thanks! Checked in at r232056.