Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[compiler-rt] Fix intermittent failure with instrprof-gcov-multithread_fork.test on 32-bit arm

Authored by rovka on Jun 15 2020, 2:39 AM.



The test fails intermittently with 'terminate called recursively' errors likely
caused by having too many threads. This patch addresses the issue by
catching any exceptions thrown during thread creation.

Diff Detail

Event Timeline

rovka created this revision.Jun 15 2020, 2:39 AM
rovka added a comment.Jun 15 2020, 2:40 AM

@calixte: Does this affect the intention of the test in any way?

The base patch is not the correct one:
Oh I think I understand: the patch I made has been uplifted in branch 10 ( but no the test fix:
So you must uplift patch in D79621 in branch 10 and if the issue is still there then add the try...catch like in D81650.
If it isn't clear enough then you can reach me on irc or discord.

rovka abandoned this revision.Jun 15 2020, 8:52 AM

Note, these files have nothing to do with instrprof, so they should be named gcov-*, rather than instrprof-gcov-*