After D81326: lld: improve the `-arch` handling for MachO landed, some tests started failing if they did not have -arch specified. I think one of the reasons happened was due to the fact that we were taking a reference to a temporary value that was freed too early. Fixing that got the error to go away on my local Linux machine. I'm actually wondering if it's still possible for our tests to fail if they run on 32-bit x86 machines -- we specify REQUIRES: x86, but REQUIRES: x86_64 doesn't seem to be a valid setting -- but in practice the tests seem to pass on Harbormaster, so I guess it's fine...?
Details
Details
- Reviewers
MaskRay - Group Reviewers
Restricted Project - Commits
- rG51c5baacf36f: [lld-macho] No need to explicitly specify -arch in tests
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
we specify REQUIRES: x86, but REQUIRES: x86_64 doesn't seem to be a valid setting -- but in practice the tests seem to pass on Harbormaster, so I guess it's fine...?
lld/test/lit.cfg.py defines:
llvm_config.feature_config( [('--build-mode', {'DEBUG': 'debug'}), ('--assertion-mode', {'ON': 'asserts'}), ('--targets-built', {'AArch64': 'aarch64', 'AMDGPU': 'amdgpu', 'ARM': 'arm', 'AVR': 'avr', 'Hexagon': 'hexagon', 'Mips': 'mips', 'MSP430': 'msp430', 'PowerPC': 'ppc', 'RISCV': 'riscv', 'Sparc': 'sparc', 'WebAssembly': 'wasm', 'X86': 'x86'}) ])
x86_64 is not a lit feature.