Page MenuHomePhabricator

[OpenMPOPT][NFC] Introducing OMPInformationCache
ClosedPublic

Authored by sstefan1 on Jun 13 2020, 3:06 PM.

Details

Summary

Introduction of OpenMP-specific information cache based on Attributor's InformationCache. This should make it easier to share information between them.
This also defines some basic information about ICVs in OMPKinds.def.

Diff Detail

Event Timeline

sstefan1 created this revision.Jun 13 2020, 3:06 PM
Herald added a project: Restricted Project. · View Herald Transcript

This is the first split of D81788

Can you split the rest into 1) NFC create and populate Cache, and 2) Introduce ICVs. I think the first is trivial. For the second we might need a way to test it. Would be interesting to have a cmd line flag to dump the ICV state at the beginning of each function. For now that would print their defaults but that is fine too.

llvm/lib/Transforms/IPO/OpenMPOpt.cpp
149

Feel free to commit this part as NFC.

sstefan1 updated this revision to Diff 271090.Jun 16 2020, 7:30 AM

left out icv part for another patch

sstefan1 retitled this revision from [OpenMPOPT][NFC] OMPInformationCache and ICV definitions. to [OpenMPOPT][NFC] Introducing OMPInformationCache.Jun 16 2020, 7:32 AM
jdoerfert accepted this revision.Jun 16 2020, 11:26 AM

LGTM. Thx!

This revision is now accepted and ready to land.Jun 16 2020, 11:26 AM
This revision was automatically updated to reflect the committed changes.