Page MenuHomePhabricator

[ELF] Fixing an issue in Elf_Note_Impl::getDescAsStringRef
ClosedPublic

Authored by dbhaskaran on Jun 11 2020, 7:01 AM.

Details

Summary

Fix in getDescAsStringRef to not use a reference to a
temporary type and added a testcase.

Diff Detail

Event Timeline

dbhaskaran created this revision.Jun 11 2020, 7:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2020, 7:01 AM
scott.linder accepted this revision.Jun 11 2020, 2:22 PM
scott.linder added inline comments.
llvm/include/llvm/Object/ELFTypes.h
620

Could you just use the full type here?

This revision is now accepted and ready to land.Jun 11 2020, 2:22 PM

updated with scott.linder's comment.

dbhaskaran marked an inline comment as done.Jun 11 2020, 10:25 PM
scott.linder accepted this revision.Jun 12 2020, 1:32 PM

Fixed clang-tidy warnings.

This revision was automatically updated to reflect the committed changes.