This is an archive of the discontinued LLVM Phabricator instance.

[mlir][linalg] Add a builder for `linalg.(indexed_)generic`.
ClosedPublic

Authored by pifon2a on Jun 10 2020, 12:39 PM.

Diff Detail

Event Timeline

pifon2a created this revision.Jun 10 2020, 12:39 PM
nicolasvasilache accepted this revision.Jun 10 2020, 1:22 PM

Quick FMI, did you see the more sugared makeGenericLinalgOp version and its use here https://github.com/llvm/llvm-project/blob/19e5b2bccb4c93f85ca098528f9fa42344e8312f/mlir/lib/Dialect/Linalg/EDSC/Builders.cpp#L329 ?
I'd welcome and indexed version of this that does the same thing with additional IV insertion into blocks.

Unlike the other more controversial implicit builder pieces, this should be kosher enough to be used anywhere, it is just a better Linalg builder that uses more structured (pun intended) helper structs.

This revision is now accepted and ready to land.Jun 10 2020, 1:22 PM
Harbormaster completed remote builds in B59869: Diff 269950.
This revision was automatically updated to reflect the committed changes.