[libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03)

[miyuki]

Summary

The test is failing on 32-bit targets in C++03 mode. Clang produces
the following warning: 'integer literal is too large to be represented
in type 'long' and is subject to undefined behavior under C++98,
interpreting as 'unsigned long'; this literal will have type 'long
long' in C++11 onwards [-Wc++11-compat]' which is promoted to an error
and causes the test to fail.

There have been no changes in the test itself since 2019, so it looks
like the diagnostic has been updated.

[miscco]

Do we need to reenable the test somewhere?

[ldionne]

In D81559#2085002, @miscco wrote:

Do we need to reenable the test somewhere?

My understanding is that it was never disabled, it just started failing with a recent compiler. @miyuki is that correct?

[miyuki]

In D81559#2085031, @ldionne wrote:

In D81559#2085002, @miscco wrote:

Do we need to reenable the test somewhere?

My understanding is that it was never disabled, it just started failing with a recent compiler. @miyuki is that correct?

Yes. Probably C++03 + 32-bit target is not a common configuration, and it is not being tested by the public build bots, so it hasn't been reported.

[miscco]

Thanks, that was what i expected but wanted to be safe

libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp

#endif // TEST_COMPILER_C1XX
     // be done with `memcpy`.
     std::vector<B2*> v(array, array + 1);
     assert(v[0] == &z);
   }
   {
     // Though the types are different, initialization can be done with `memcpy`.
     int32_t array[1] = { -1 };
     std::vector<uint32_t> v(array, array + 1);
-    assert(v[0] == 4294967295);
+    assert(v[0] == 4294967295U);
   }
 }
 
 
 int main(int, char**) {
   basic_test_cases();
   emplaceable_concept_tests(); // See PR34898
   test_ctor_under_alloc();
   test_ctor_with_different_value_type();
 
   return 0;
 }