This is an archive of the discontinued LLVM Phabricator instance.

Differential D81366

Recognize *.hxx as a C++ header extension, like *.hpp.
ClosedPublic

Authored by sammccall on Jun 8 2020, 1:55 AM.

Details

Reviewers
kadircet
Commits
rG9c3909556b31: Recognize *.hxx as a C++ header extension, like *.hpp.

Diff Detail

Unit TestsFailed

TimeTest
60 mswindows > Clang.CodeGen::Unknown Unit Message ("")

Event Timeline

sammccall created this revision.Jun 8 2020, 1:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2020, 1:55 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kadircet accepted this revision.Jun 8 2020, 2:09 AM
This revision is now accepted and ready to land.Jun 8 2020, 2:09 AM
Harbormaster failed remote builds in B59433: Diff 269125!Jun 8 2020, 2:41 AM
Closed by commit rG9c3909556b31: Recognize *.hxx as a C++ header extension, like *.hpp. (authored by sammccall). · Explain WhyJun 8 2020, 3:14 AM
This revision was automatically updated to reflect the committed changes.
nridge mentioned this in D140191: [CodeComplete] Offer completions for headers with extension .hxx in include directives.Dec 16 2022, 12:36 AM

Revision Contents

PathSize
clang/
lib/
Driver/
1 line
Frontend/
2 lines

Diff 269125

clang/lib/Driver/Types.cpp

//===--- Types.cpp - Driver input & temporary type information ------------===// //===--- Types.cpp - Driver input & temporary type information ------------===//
Lint: Lint
Inline Actions

clang-format suggested style edits found:

Lint: Lint: clang-format suggested style edits found:
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "clang/Driver/Types.h" #include "clang/Driver/Types.h"
▲ Show 20 Lines • Show All 216 Lines • ▼ Show 20 Lines
} }
bool types::isSrcFile(ID Id) { bool types::isSrcFile(ID Id) {
return Id != TY_Object && getPreprocessedType(Id) != TY_INVALID; return Id != TY_Object && getPreprocessedType(Id) != TY_INVALID;
} }
types::ID types::lookupTypeForExtension(llvm::StringRef Ext) { types::ID types::lookupTypeForExtension(llvm::StringRef Ext) {
return llvm::StringSwitch<types::ID>(Ext) return llvm::StringSwitch<types::ID>(Ext)
.Case("c", TY_C) .Case("c", TY_C)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-           .Case("c", TY_C)
-           .Case("C", TY_CXX)
-           .Case("F", TY_Fortran)
-           .Case("f", TY_PP_Fortran)
-           .Case("h", TY_CHeader)
-           .Case("H", TY_CXXHeader)
-           .Case("i", TY_PP_C)
-           .Case("m", TY_ObjC)
-           .Case("M", TY_ObjCXX)
-           .Case("o", TY_Object)

108 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - .Case("c", TY_C) - .Case("C"…
.Case("C", TY_CXX) .Case("C", TY_CXX)
.Case("F", TY_Fortran) .Case("F", TY_Fortran)
.Case("f", TY_PP_Fortran) .Case("f", TY_PP_Fortran)
.Case("h", TY_CHeader) .Case("h", TY_CHeader)
.Case("H", TY_CXXHeader) .Case("H", TY_CXXHeader)
.Case("i", TY_PP_C) .Case("i", TY_PP_C)
.Case("m", TY_ObjC) .Case("m", TY_ObjC)
.Case("M", TY_ObjCXX) .Case("M", TY_ObjCXX)
Show All 30 Lines return llvm::StringSwitch<types::ID>(Ext)
.Case("f95", TY_PP_Fortran) .Case("f95", TY_PP_Fortran)
.Case("for", TY_PP_Fortran) .Case("for", TY_PP_Fortran)
.Case("FOR", TY_PP_Fortran) .Case("FOR", TY_PP_Fortran)
.Case("fpp", TY_Fortran) .Case("fpp", TY_Fortran)
.Case("FPP", TY_Fortran) .Case("FPP", TY_Fortran)
.Case("gch", TY_PCH) .Case("gch", TY_PCH)
.Case("hip", TY_HIP) .Case("hip", TY_HIP)
.Case("hpp", TY_CXXHeader) .Case("hpp", TY_CXXHeader)
.Case("hxx", TY_CXXHeader)
.Case("iim", TY_PP_CXXModule) .Case("iim", TY_PP_CXXModule)
.Case("lib", TY_Object) .Case("lib", TY_Object)
.Case("mii", TY_PP_ObjCXX) .Case("mii", TY_PP_ObjCXX)
.Case("obj", TY_Object) .Case("obj", TY_Object)
.Case("ifs", TY_IFS) .Case("ifs", TY_IFS)
.Case("pch", TY_PCH) .Case("pch", TY_PCH)
.Case("pcm", TY_ModuleFile) .Case("pcm", TY_ModuleFile)
.Case("c++m", TY_CXXModule) .Case("c++m", TY_CXXModule)
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines

clang/lib/Frontend/FrontendOptions.cpp

Show All 19 Lines return llvm::StringSwitch<InputKind>(Extension)
.Case("i", InputKind(Language::C).getPreprocessed()) .Case("i", InputKind(Language::C).getPreprocessed())
.Case("ii", InputKind(Language::CXX).getPreprocessed()) .Case("ii", InputKind(Language::CXX).getPreprocessed())
.Case("cui", InputKind(Language::CUDA).getPreprocessed()) .Case("cui", InputKind(Language::CUDA).getPreprocessed())
.Case("m", Language::ObjC) .Case("m", Language::ObjC)
.Case("mi", InputKind(Language::ObjC).getPreprocessed()) .Case("mi", InputKind(Language::ObjC).getPreprocessed())
.Cases("mm", "M", Language::ObjCXX) .Cases("mm", "M", Language::ObjCXX)
.Case("mii", InputKind(Language::ObjCXX).getPreprocessed()) .Case("mii", InputKind(Language::ObjCXX).getPreprocessed())
.Cases("C", "cc", "cp", Language::CXX) .Cases("C", "cc", "cp", Language::CXX)
.Cases("cpp", "CPP", "c++", "cxx", "hpp", Language::CXX) .Cases("cpp", "CPP", "c++", "cxx", "hpp", "hxx", Language::CXX)
.Case("cppm", Language::CXX) .Case("cppm", Language::CXX)
.Case("iim", InputKind(Language::CXX).getPreprocessed()) .Case("iim", InputKind(Language::CXX).getPreprocessed())
.Case("cl", Language::OpenCL) .Case("cl", Language::OpenCL)
.Case("cu", Language::CUDA) .Case("cu", Language::CUDA)
.Case("hip", Language::HIP) .Case("hip", Language::HIP)
.Cases("ll", "bc", Language::LLVM_IR) .Cases("ll", "bc", Language::LLVM_IR)
.Default(Language::Unknown); .Default(Language::Unknown);
} }