This is an archive of the discontinued LLVM Phabricator instance.

Enable -DLLDB_ENERGY when compiling against an internal SDK
ClosedPublic

Authored by aprantl on Jun 5 2020, 1:29 PM.

Details

Summary

This brings over functionality from the xcodeproject that went missing during the CMake transition.

rdar://problem/63840635

Diff Detail

Event Timeline

aprantl created this revision.Jun 5 2020, 1:29 PM
vsk accepted this revision.Jun 8 2020, 10:06 AM
This revision is now accepted and ready to land.Jun 8 2020, 10:06 AM
JDevlieghere added inline comments.Jun 8 2020, 10:49 AM
lldb/tools/debugserver/source/CMakeLists.txt
132

I guess this should be guarded by if(APPLE)?

135

Can we not use the find_library patter that we use for things like springboard above?

aprantl marked an inline comment as done.Jun 10 2020, 2:05 PM
aprantl added inline comments.
lldb/tools/debugserver/source/CMakeLists.txt
132

The whole directory is already guarded by this:

if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
  add_lldb_tool_subdirectory(darwin-debug)
  if(NOT LLDB_USE_SYSTEM_DEBUGSERVER)
    add_lldb_tool_subdirectory(debugserver)
  endif()
endif()
aprantl marked an inline comment as done.Jun 10 2020, 2:10 PM
aprantl added inline comments.
lldb/tools/debugserver/source/CMakeLists.txt
135

There isn't really anything to find. It's in /usr/lib.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2020, 2:29 PM