This is an archive of the discontinued LLVM Phabricator instance.

Differential D81252

[SVE ACLE] Remove redundant bool_t typedef.
ClosedPublic

Authored by paulwalker-arm on Jun 5 2020, 4:50 AM.

Details

Reviewers
sdesmalen
Commits
rGd6d2f78fe504: [SVE ACLE] Remove redundant bool_t typedef.

Diff Detail

Unit TestsFailed

TimeTest
2,680 msProfile-x86_64.Profile-x86_64::Unknown Unit Message ("")

Event Timeline

paulwalker-arm created this revision.Jun 5 2020, 4:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2020, 4:50 AM
Herald added subscribers: cfe-commits, tschuett. · View Herald Transcript
paulwalker-arm added a reviewer: sdesmalen.Jun 5 2020, 4:53 AM
sdesmalen accepted this revision.Jun 5 2020, 5:06 AM

LGTM

This revision is now accepted and ready to land.Jun 5 2020, 5:06 AM
Harbormaster failed remote builds in B59225: Diff 268744!Jun 5 2020, 6:01 AM
paulwalker-arm updated this revision to Diff 268795.Jun 5 2020, 7:29 AM

Stop SveEmitter adding a _t suffix to the scalar boolean type.

Harbormaster failed remote builds in B59248: Diff 268795!Jun 5 2020, 8:19 AM
Closed by commit rGd6d2f78fe504: [SVE ACLE] Remove redundant bool_t typedef. (authored by paulwalker-arm). · Explain WhyJun 6 2020, 5:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
utils/
TableGen/
4 lines

Diff 268795

clang/utils/TableGen/SveEmitter.cpp

Show First 20 Lines • Show All 431 Lines • ▼ Show 20 Lines else
S += "int"; S += "int";
if (!isScalarPredicate() && !isPredicateVector()) if (!isScalarPredicate() && !isPredicateVector())
S += utostr(ElementBitwidth); S += utostr(ElementBitwidth);
if (!isScalableVector() && isVector()) if (!isScalableVector() && isVector())
S += "x" + utostr(getNumElements()); S += "x" + utostr(getNumElements());
if (NumVectors > 1) if (NumVectors > 1)
S += "x" + utostr(NumVectors); S += "x" + utostr(NumVectors);
if (!isScalarPredicate())
S += "_t"; S += "_t";
} }
if (Constant) if (Constant)
S += " const"; S += " const";
if (Pointer) if (Pointer)
S += " *"; S += " *";
return S; return S;
▲ Show 20 Lines • Show All 604 Lines • ▼ Show 20 Linesvoid SVEEmitter::createHeader(raw_ostream &OS) {
OS << "extern \"C\" {\n"; OS << "extern \"C\" {\n";
OS << "#else\n"; OS << "#else\n";
OS << "#include <stdbool.h>\n"; OS << "#include <stdbool.h>\n";
OS << "#endif\n\n"; OS << "#endif\n\n";
OS << "typedef __fp16 float16_t;\n"; OS << "typedef __fp16 float16_t;\n";
OS << "typedef float float32_t;\n"; OS << "typedef float float32_t;\n";
OS << "typedef double float64_t;\n"; OS << "typedef double float64_t;\n";
OS << "typedef bool bool_t;\n\n";
OS << "typedef __SVInt8_t svint8_t;\n"; OS << "typedef __SVInt8_t svint8_t;\n";
OS << "typedef __SVInt16_t svint16_t;\n"; OS << "typedef __SVInt16_t svint16_t;\n";
OS << "typedef __SVInt32_t svint32_t;\n"; OS << "typedef __SVInt32_t svint32_t;\n";
OS << "typedef __SVInt64_t svint64_t;\n"; OS << "typedef __SVInt64_t svint64_t;\n";
OS << "typedef __SVUint8_t svuint8_t;\n"; OS << "typedef __SVUint8_t svuint8_t;\n";
OS << "typedef __SVUint16_t svuint16_t;\n"; OS << "typedef __SVUint16_t svuint16_t;\n";
OS << "typedef __SVUint32_t svuint32_t;\n"; OS << "typedef __SVUint32_t svuint32_t;\n";
▲ Show 20 Lines • Show All 266 Lines • Show Last 20 Lines