This is an archive of the discontinued LLVM Phabricator instance.

Correctly report modified status for TailRecursionElimination
ClosedPublic

Authored by serge-sans-paille on Jun 5 2020, 12:38 AM.

Reviewers

Commits

Summary

Looks obviously correct.

This revision is now accepted and ready to land.Jun 5 2020, 5:48 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Transforms/

Scalar/

2 lines

Show First 20 Lines • Show All 812 Lines • ▼ Show 20 Lines	bool TailRecursionEliminator::eliminate(Function &F,
bool AllCallsAreTailCalls = false;		bool AllCallsAreTailCalls = false;
MadeChange \|= markTails(F, AllCallsAreTailCalls, ORE);		MadeChange \|= markTails(F, AllCallsAreTailCalls, ORE);
if (!AllCallsAreTailCalls)		if (!AllCallsAreTailCalls)
return MadeChange;		return MadeChange;

// If this function is a varargs function, we won't be able to PHI the args		// If this function is a varargs function, we won't be able to PHI the args
// right, so don't even try to convert it...		// right, so don't even try to convert it...
if (F.getFunctionType()->isVarArg())		if (F.getFunctionType()->isVarArg())
return false;		return MadeChange;

// If false, we cannot perform TRE on tail calls marked with the 'tail'		// If false, we cannot perform TRE on tail calls marked with the 'tail'
// attribute, because doing so would cause the stack size to increase (real		// attribute, because doing so would cause the stack size to increase (real
// TRE would deallocate variable sized allocas, TRE doesn't).		// TRE would deallocate variable sized allocas, TRE doesn't).
bool CanTRETailMarkedCall = canTRE(F);		bool CanTRETailMarkedCall = canTRE(F);

TailRecursionEliminator TRE(F, TTI, AA, ORE, DTU);		TailRecursionEliminator TRE(F, TTI, AA, ORE, DTU);

▲ Show 20 Lines • Show All 93 Lines • Show Last 20 Lines