This is an archive of the discontinued LLVM Phabricator instance.

Paths

Correctly report modified status for SCCP
ClosedPublic

Authored by serge-sans-paille on Jun 5 2020, 12:30 AM.

Reviewers

Commits

Summary

LGTM, thanks! A slightly more descriptive commit message might be [SCCP] Report changes after removing stores to constant global.

This revision is now accepted and ready to land.Jun 5 2020, 1:53 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Transforms/

Scalar/

1 line

Show First 20 Lines • Show All 2,025 Lines • ▼ Show 20 Lines	for (auto &I : make_early_inc_range(Solver.getTrackedGlobals())) {
GlobalVariable *GV = I.first;		GlobalVariable *GV = I.first;
if (isOverdefined(I.second))		if (isOverdefined(I.second))
continue;		continue;
LLVM_DEBUG(dbgs() << "Found that GV '" << GV->getName()		LLVM_DEBUG(dbgs() << "Found that GV '" << GV->getName()
<< "' is constant!\n");		<< "' is constant!\n");
while (!GV->use_empty()) {		while (!GV->use_empty()) {
StoreInst *SI = cast<StoreInst>(GV->user_back());		StoreInst *SI = cast<StoreInst>(GV->user_back());
SI->eraseFromParent();		SI->eraseFromParent();
		MadeChanges = true;
}		}
M.getGlobalList().erase(GV);		M.getGlobalList().erase(GV);
++IPNumGlobalConst;		++IPNumGlobalConst;
}		}

return MadeChanges;		return MadeChanges;
}		}