[ELF] Adding accessor method for getting Note Desc as StringRef

[dineshkb-amd]

Summary

One more way to access note desc.

[dineshkb-amd]

Updated to use reference.

[arsenm]

llvm/include/llvm/Object/ELFTypes.h

609

I would move this below getDesc()

[scott.linder]

I don't know why I didn't add any tests of getDesc() (or anything else) originally, maybe because there is no existing testing and it requires both a unit test and a binary file input? I think at this point we shouldn't block adding an obvious 1-line function on adding tests that should already exist. So, LGTM with Matt's request addressed, and we can add testing in a general way at some point.

[dineshkb-amd]

Updated arsenm's comment.

llvm/include/llvm/Object/ELFTypes.h

public:
   /// Get the note's name, excluding the terminating null byte.
   StringRef getName() const {
     if (!Nhdr.n_namesz)
       return StringRef();
     return StringRef(reinterpret_cast<const char *>(&Nhdr) + sizeof(Nhdr),
                      Nhdr.n_namesz - 1);
   }
 
+  /// Get the note's descriptor as StringRef
+  StringRef getDescAsStringRef() const {
+    auto &Desc = getDesc();
+    return StringRef(reinterpret_cast<const char *>(Desc.data()), Desc.size());
+  }
+
   /// Get the note's descriptor.
   ArrayRef<uint8_t> getDesc() const {
     if (!Nhdr.n_descsz)
       return ArrayRef<uint8_t>();
     return ArrayRef<uint8_t>(
         reinterpret_cast<const uint8_t *>(&Nhdr) + sizeof(Nhdr) +
           alignTo<Elf_Nhdr_Impl<ELFT>::Align>(Nhdr.n_namesz),
         Nhdr.n_descsz);