[Scalar] Fix assignment operator for long long.

[werat]

Summary

Assignment operator operator=(long long) currently allocates sizeof(long).
On some platforms it works as they have sizeof(long) == sizeof(long long),
but on others (e.g. Windows) it's not the case.

[labath]

Looks good. Given the timings, I am going to assume you are coordinating with @miko.

[werat]

In D80995#2068571, @labath wrote:

Looks good. Given the timings, I am going to assume you are coordinating with @miko.

Thanks! This is very surprising, but we're not coordinating. I've found out about their patch just now. Apparently it was submitted while I was reading the documentation about how to submit mine :D

I see @miko has closed their review in favor of this one.

@labath, I don't have commit rights. Can you, please, commit this patch? Thanks!

lldb/source/Utility/Scalar.cpp

 Scalar &Scalar::operator=(unsigned long v) {
   m_type = e_ulong;
   m_integer = llvm::APInt(sizeof(long) * 8, v);
   return *this;
 }
 
 Scalar &Scalar::operator=(long long v) {
   m_type = e_slonglong;
-  m_integer = llvm::APInt(sizeof(long) * 8, v, true);
+  m_integer = llvm::APInt(sizeof(long long) * 8, v, true);
   return *this;
 }
 
 Scalar &Scalar::operator=(unsigned long long v) {
   m_type = e_ulonglong;
   m_integer = llvm::APInt(sizeof(long long) * 8, v);
   return *this;
 }

lldb/unittests/Utility/ScalarTest.cpp

TEST(ScalarTest, GetValue) {
   EXPECT_EQ("-1234567890123",
             ScalarGetValue<signed long long>(-1234567890123LL));
   EXPECT_EQ("1234567890123",
             ScalarGetValue<unsigned long long>(1234567890123ULL));
   EXPECT_EQ(std::to_string(std::numeric_limits<unsigned long long>::max()),
             ScalarGetValue(std::numeric_limits<unsigned long long>::max()));
 }
 
+TEST(ScalarTest, LongLongAssigmentOperator) {
+  Scalar ull;
+  ull = std::numeric_limits<unsigned long long>::max();
+  EXPECT_EQ(std::numeric_limits<unsigned long long>::max(), ull.ULongLong());
+
+  Scalar sll;
+  sll = std::numeric_limits<signed long long>::max();
+  EXPECT_EQ(std::numeric_limits<signed long long>::max(), sll.SLongLong());
+}
+
 TEST(ScalarTest, Division) {
   Scalar lhs(5.0);
   Scalar rhs(2.0);
   Scalar r = lhs / rhs;
   EXPECT_TRUE(r.IsValid());
   EXPECT_EQ(r, Scalar(2.5));
 }