Page MenuHomePhabricator

[Scalar] Fix assignment operator for long long.
ClosedPublic

Authored by werat on Jun 2 2020, 5:28 AM.

Details

Summary

Assignment operator operator=(long long) currently allocates sizeof(long).
On some platforms it works as they have sizeof(long) == sizeof(long long),
but on others (e.g. Windows) it's not the case.

Diff Detail

Event Timeline

werat created this revision.Jun 2 2020, 5:28 AM
werat added a reviewer: teemperor.
labath accepted this revision.Jun 2 2020, 5:40 AM
labath added a subscriber: miko.

Looks good. Given the timings, I am going to assume you are coordinating with @miko.

This revision is now accepted and ready to land.Jun 2 2020, 5:40 AM
werat added a comment.Jun 2 2020, 6:31 AM

Looks good. Given the timings, I am going to assume you are coordinating with @miko.

Thanks! This is very surprising, but we're not coordinating. I've found out about their patch just now. Apparently it was submitted while I was reading the documentation about how to submit mine :D

I see @miko has closed their review in favor of this one.

@labath, I don't have commit rights. Can you, please, commit this patch? Thanks!

This revision was automatically updated to reflect the committed changes.