This is an archive of the discontinued LLVM Phabricator instance.

[mlir][spirv] Fix coop matrix getExtension.
ClosedPublic

Authored by ThomasRaoux on Jun 1 2020, 1:11 PM.

Details

Summary

Stack variable was being used beyond its lifetime.

Diff Detail

Event Timeline

ThomasRaoux created this revision.Jun 1 2020, 1:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2020, 1:11 PM
ThomasRaoux retitled this revision from [mlir][spirv] Fix Fix coop matrix getExtension. to [mlir][spirv] Fix coop matrix getExtension..Jun 1 2020, 1:11 PM
antiagainst accepted this revision.Jun 2 2020, 1:16 PM

Ah yes! Good catch on this one. We are trying to avoid allocating SmallVectors of SmallVectors. so SmallVectors of ArrayRefs. It does mean that the lifetime management become more manual..

This revision is now accepted and ready to land.Jun 2 2020, 1:16 PM
This revision was automatically updated to reflect the committed changes.