This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add IntrWillReturn to intrinsic definitions
ClosedPublic

Authored by arsenm on May 28 2020, 8:54 AM.

Details

Reviewers
rampitec
nhaehnle
Summary

This should probably be implied for all the speculatable ones. I think
the only ones where this plausibly doesn't apply is s_sendmsghalt and
maybe kill.

Diff Detail

Event Timeline

arsenm created this revision.May 28 2020, 8:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2020, 8:54 AM
Herald added subscribers: kerbowa, t-tye, tpr and 5 others. · View Herald Transcript
rampitec added inline comments.May 28 2020, 10:03 AM
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
188

I am not sure this one always will return. With zero input it is a kill.

arsenm marked an inline comment as done.May 28 2020, 10:28 AM
arsenm added inline comments.
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
188

I would expect a shader to never be launched with 0 input? I think it's also not clear if kill is really a return

rampitec added inline comments.May 28 2020, 10:59 AM
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
188

I do not really know if someone may use it this way or not. Is it important to mark it?

arsenm marked an inline comment as done.May 28 2020, 11:28 AM
arsenm added inline comments.
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
188

Marek says it wouldn't be called with 0

rampitec accepted this revision.May 28 2020, 11:34 AM
This revision is now accepted and ready to land.May 28 2020, 11:34 AM
arsenm closed this revision.Jun 18 2020, 12:39 PM

f0abefaf50867f8a046aee9c8c1fe980dc24e2c8. I dropped the ones that touch exec since I'm not really sure what returns means in that context