This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Make createCounter a virtual method on Target to allow targets to create target-specific counters
ClosedPublic

Authored by oontvoo on May 26 2020, 9:15 PM.

Diff Detail

Event Timeline

oontvoo created this revision.May 26 2020, 9:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2020, 9:15 PM
oontvoo updated this revision to Diff 266417.EditedMay 26 2020, 9:22 PM

fix accidentally mixed-up branches

P.S: actually still not fixed. i've sorted out the branches locally and re-run arc diff but that didn't seem to fix it. Any idea which else to try?

oontvoo edited the summary of this revision. (Show Details)May 26 2020, 9:24 PM

Can you also include making the Counter virtual, and the use of this new function in FunctionExecutorImpl::runAndMeasure ? This would remove more unrelated changes from the other patch.

oontvoo updated this revision to Diff 266671.May 27 2020, 2:17 PM

Move non-LBR related changes from benchmarkrunner and PerfHelper over too.

oontvoo updated this revision to Diff 266683.May 27 2020, 3:19 PM

Sync/rebase

courbet accepted this revision.May 28 2020, 12:30 AM

LGTM modulo one comment.

llvm/tools/llvm-exegesis/lib/PerfHelper.h
85 ↗(On Diff #266683)

I don't think this needs to be virtual, does it ? readOrError is the real thing.

This revision is now accepted and ready to land.May 28 2020, 12:30 AM
oontvoo updated this revision to Diff 266857.May 28 2020, 6:51 AM

Make read() non-virtual

oontvoo marked an inline comment as done.May 28 2020, 6:52 AM