This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readelf] - Split GNUStyle<ELFT>::printHashHistogram. NFC.
ClosedPublic

Authored by grimar on May 26 2020, 4:06 AM.

Details

Summary

As was mentioned in review comments for D80204,
printHashHistogram has 2 lambdas that are probably too large
and deserves splitting into member functions.

This patch does it.

Depends on D80204.

Diff Detail

Event Timeline

grimar created this revision.May 26 2020, 4:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2020, 4:06 AM
Herald added a subscriber: rupprecht. · View Herald Transcript
MaskRay accepted this revision.May 26 2020, 5:14 PM

Looks great!

This revision is now accepted and ready to land.May 26 2020, 5:14 PM
jhenderson accepted this revision.May 27 2020, 1:28 AM

LGTM, with suggested comment fixes.

llvm/tools/llvm-readobj/ELFDumper.cpp
4667

Whilst you're moving the comment, let's fix it:

Nit: double space between "shows" and "statistics".

4668

shows the number

4669

as an absolute number

4670

buckets. Additionally cumulative -> buckets, and the cumulative

This revision was automatically updated to reflect the committed changes.
grimar marked 4 inline comments as done.