This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Fix formatting for the 'aix-ld.c' test case.
ClosedPublic

Authored by stevewan on May 25 2020, 1:18 PM.

Details

Summary

Based on comments received in D80415 pertinent to test case format, the following fixes are provided to other tests in 'aix-ld.c' for the sake of consistency and readability,

  • Align flags in RUN directives vertically.
  • Align patterns in CHECK directives vertically.
  • Remove the ‘-o %t.o’ as it’s unnecessary for tests with ‘-###’.
  • Fix typos in comments.

Diff Detail

Event Timeline

stevewan created this revision.May 25 2020, 1:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2020, 1:18 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
stevewan edited the summary of this revision. (Show Details)
stevewan updated this revision to Diff 266070.May 25 2020, 1:25 PM

Fix misalignment caused by tab.

stevewan updated this revision to Diff 266081.May 25 2020, 2:59 PM

Pass 'clang-format' checking.

hubert.reinterpretcast marked an inline comment as done.May 25 2020, 3:14 PM

LGTM with minor comment.

clang/test/Driver/aix-ld.c
8

The two-space indent for continuations on a pipeline or similar boundary was intentional. We're only somewhat okay here because the non-terminal commands are all multiline deep indentation. I think we should retain the two-space indent.

59

Good catch.

stevewan updated this revision to Diff 266263.May 26 2020, 10:22 AM

Add the two-space indent before continuations on a pipeine.

stevewan marked an inline comment as done.May 26 2020, 10:22 AM
This revision is now accepted and ready to land.May 26 2020, 12:18 PM
This revision was automatically updated to reflect the committed changes.