Page MenuHomePhabricator

[runtimes] Pass COMPILER_RT* through to runtime build
AbandonedPublic

Authored by russell.gallop on May 22 2020, 8:46 AM.

Details

Reviewers
phosek
beanz
Summary

Without this COMPILER_RT_BUILD_SANITIZERS=OFF etc. would not work with cross compilation (e.g. with LLVM_ENABLE_RUNTIMES=compiler-rt)

Diff Detail

Event Timeline

russell.gallop created this revision.May 22 2020, 8:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 22 2020, 8:46 AM
Herald added a subscriber: mgorny. · View Herald Transcript

This needs be done on a per-target basis, not globally (e.g. you may want to use COMPILER_RT_BUILD_SANITIZERS=OFF for target1 but not target2). Have you tried setting RUNTIMES_${target}_COMPILER_RT_BUILD_SANITIZERS=OFF? This should be already supported, see for example https://github.com/llvm/llvm-project/blob/master/clang/cmake/caches/Fuchsia-stage2.cmake#L100

russell.gallop abandoned this revision.May 29 2020, 3:11 AM

This needs be done on a per-target basis, not globally (e.g. you may want to use COMPILER_RT_BUILD_SANITIZERS=OFF for target1 but not target2). Have you tried setting RUNTIMES_${target}_COMPILER_RT_BUILD_SANITIZERS=OFF? This should be already supported, see for example https://github.com/llvm/llvm-project/blob/master/clang/cmake/caches/Fuchsia-stage2.cmake#L100

Thanks, that works, and looks better so I'll close this review.