This is an archive of the discontinued LLVM Phabricator instance.

Differential D80243

[compiler-rt][scudo][LIT] Use target_suffix instead of target-arch
ClosedPublic

Authored by jsji on May 19 2020, 2:06 PM.

Details

Reviewers
cryptoad
phosek
Commits
rG8d0fdd44eef6: [compiler-rt][scudo][LIT] Use target_suffix instead of target-arch
Summary

Per target runtime dir may change the suffix of shared libs.
We can not assume we are always building with per_target_runtime_dir on.

Diff Detail

Unit TestsFailed

TimeTest
150 msClang.CodeGen::Unknown Unit Message ("")
270 msClang.CodeGen::Unknown Unit Message ("")
50 msClang.Profile::Unknown Unit Message ("")
50 msClang.Profile::Unknown Unit Message ("")
70 msClang.Profile::Unknown Unit Message ("")
View Full Test Results (120 Failed)

Event Timeline

jsji created this revision.May 19 2020, 2:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2020, 2:06 PM
Herald added subscribers: Restricted Project, dberris. · View Herald Transcript
jsji edited the summary of this revision. (Show Details)May 19 2020, 2:16 PM
cryptoad accepted this revision.May 19 2020, 2:24 PM
This revision is now accepted and ready to land.May 19 2020, 2:24 PM
Harbormaster failed remote builds in B57265: Diff 265034!May 19 2020, 2:54 PM
Closed by commit rG8d0fdd44eef6: [compiler-rt][scudo][LIT] Use target_suffix instead of target-arch (authored by jsji). · Explain WhyMay 19 2020, 8:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
test/
scudo/
2 lines

Diff 265034

compiler-rt/test/scudo/lit.cfg.py

# -*- Python -*- # -*- Python -*-
import os import os
# Setup config name. # Setup config name.
config.name = 'Scudo' + config.name_suffix config.name = 'Scudo' + config.name_suffix
# Setup source root. # Setup source root.
config.test_source_root = os.path.dirname(__file__) config.test_source_root = os.path.dirname(__file__)
# Path to the shared library # Path to the shared library
shared_libscudo = os.path.join(config.compiler_rt_libdir, "libclang_rt.scudo%s.so" % config.target_suffix) shared_libscudo = os.path.join(config.compiler_rt_libdir, "libclang_rt.scudo%s.so" % config.target_suffix)
shared_minlibscudo = os.path.join(config.compiler_rt_libdir, "libclang_rt.scudo_minimal-%s.so" % config.target_arch) shared_minlibscudo = os.path.join(config.compiler_rt_libdir, "libclang_rt.scudo_minimal%s.so" % config.target_suffix)
# Test suffixes. # Test suffixes.
config.suffixes = ['.c', '.cpp', '.test'] config.suffixes = ['.c', '.cpp', '.test']
# C & CXX flags. # C & CXX flags.
c_flags = ([config.target_cflags] + c_flags = ([config.target_cflags] +
["-pthread", ["-pthread",
"-fPIE", "-fPIE",
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines