[analyzer] SATestBuild.py: Optionally override compiler

[vsavchenko]

Summary

It is good to have a way to control this behavior manually.

[NoQ]

Ideally we should be able to control it on per-project basis(?)

[vsavchenko]

I agree, but I think we should refactor a bit how we process command line arguments before that.

clang/utils/analyzer/SATestBuild.py

def runScanBuild(Args, Dir, SBOutputDir, PBuildLogFile):
     SBCwd = os.path.join(Dir, PatchedSourceDirName)
 
     SBOptions = "--use-analyzer '%s' " % Clang
     SBOptions += "-plist-html -o '%s' " % SBOutputDir
     SBOptions += "-enable-checker " + AllCheckers + " "
     SBOptions += "--keep-empty "
     SBOptions += "-analyzer-config '%s' " % generateAnalyzerConfig(Args)
 
-    # Always use ccc-analyze to ensure that we can locate the failures
-    # directory.
+    if Args.override_compiler:
         SBOptions += "--override-compiler "
+
     ExtraEnv = {}
     try:
         SBCommandFile = open(BuildScriptPath, "r")
         SBPrefix = "scan-build " + SBOptions + " "
         for Command in SBCommandFile:
             Command = Command.strip()
             if len(Command) == 0:
                 continue
Parser = argparse.ArgumentParser(
         description='Test the Clang Static Analyzer.')
     Parser.add_argument('--strictness', dest='strictness', type=int, default=0,
                         help='0 to fail on runtime errors, 1 to fail when the \
                              number of found bugs are different from the \
                              reference, 2 to fail on any difference from the \
                              reference. Default is 0.')
     Parser.add_argument('-r', dest='regenerate', action='store_true',
                         default=False, help='Regenerate reference output.')
+    Parser.add_argument('--override-compiler', action='store_true',
+                        default=False, help='Call scan-build with \
+                        --override-compiler option.')
     Parser.add_argument('-j', '--jobs', dest='jobs', type=int,
                         default=0,
                         help='Number of projects to test concurrently')
-    Parser.add_argument('--extra-analyzer-config', dest='extra_analyzer_config',
-                        type=str,
+    Parser.add_argument('--extra-analyzer-config',
+                        dest='extra_analyzer_config', type=str,
                         default="",
                         help="Arguments passed to to -analyzer-config")
     Args = Parser.parse_args()
 
     TestsPassed = testAll(Args)
     if not TestsPassed:
         print("ERROR: Tests failed.")
         sys.exit(42)