Page MenuHomePhabricator

[llvm-readobj][test] - Deduplicate YAMLs in gnuhash.test and hash-table.test. NFCI.
ClosedPublic

Authored by grimar on Tue, May 19, 2:46 AM.

Details

Summary

We can use -D to generalize inputs. This patch does it.

Diff Detail

Event Timeline

grimar created this revision.Tue, May 19, 2:46 AM
Herald added a project: Restricted Project. · View Herald Transcript
MaskRay accepted this revision.Tue, May 19, 9:11 AM

LGTM.

This revision is now accepted and ready to land.Tue, May 19, 9:11 AM
jhenderson accepted this revision.Wed, May 20, 1:37 AM

LGTM. FWIW, I don't think it's necessary to use different MACHINE values in most cases, since I don't think llvm-readobj's behaviour should change based on the machine type, only on the ELF64/ELF32 nature.

FWIW, I don't think it's necessary to use different MACHINE values in most cases, since I don't think llvm-readobj's behaviour should change based on the machine type, only on the ELF64/ELF32 nature.

Yeah, but it looks a bit inaccurate to me..

This revision was automatically updated to reflect the committed changes.