This is an archive of the discontinued LLVM Phabricator instance.

Differential D80183

[mlir][vulkan-runner] Minor fix in timestamp flag for vulkan runner.
ClosedPublic

Authored by ThomasRaoux on May 18 2020, 9:42 PM.

Details

Reviewers
antiagainst
Commits
rG92577e6a0f73: [mlir][vulkan-runner] Minor fix in timestamp flag for vulkan runner.
Summary

The first timestamp query should use VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT.

Diff Detail

Event Timeline

ThomasRaoux created this revision.May 18 2020, 9:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2020, 9:42 PM
Herald added subscribers: llvm-commits, jurahul, Kayjukh and 13 others. · View Herald Transcript
Harbormaster failed remote builds in B57161: Diff 264790!May 18 2020, 10:45 PM
antiagainst accepted this revision.May 19 2020, 6:03 AM

Thanks for catching and fixing this, Thomas!

This revision is now accepted and ready to land.May 19 2020, 6:03 AM
Closed by commit rG92577e6a0f73: [mlir][vulkan-runner] Minor fix in timestamp flag for vulkan runner. (authored by ThomasRaoux). · Explain WhyMay 19 2020, 7:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
tools/
mlir-vulkan-runner/
2 lines

Diff 265114

mlir/tools/mlir-vulkan-runner/VulkanRuntime.cpp

Show First 20 Lines • Show All 722 Lines • ▼ Show 20 Lines if (queryPool != VK_NULL_HANDLE)
vkCmdResetQueryPool(commandBuffer, queryPool, 0, 2); vkCmdResetQueryPool(commandBuffer, queryPool, 0, 2);
vkCmdBindPipeline(commandBuffer, VK_PIPELINE_BIND_POINT_COMPUTE, pipeline); vkCmdBindPipeline(commandBuffer, VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
vkCmdBindDescriptorSets(commandBuffer, VK_PIPELINE_BIND_POINT_COMPUTE, vkCmdBindDescriptorSets(commandBuffer, VK_PIPELINE_BIND_POINT_COMPUTE,
pipelineLayout, 0, descriptorSets.size(), pipelineLayout, 0, descriptorSets.size(),
descriptorSets.data(), 0, 0); descriptorSets.data(), 0, 0);
// Get a timestamp before invoking the compute shader. // Get a timestamp before invoking the compute shader.
if (queryPool != VK_NULL_HANDLE) if (queryPool != VK_NULL_HANDLE)
vkCmdWriteTimestamp(commandBuffer, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, vkCmdWriteTimestamp(commandBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT,
queryPool, 0); queryPool, 0);
vkCmdDispatch(commandBuffer, numWorkGroups.x, numWorkGroups.y, vkCmdDispatch(commandBuffer, numWorkGroups.x, numWorkGroups.y,
numWorkGroups.z); numWorkGroups.z);
// Get another timestamp after invoking the compute shader. // Get another timestamp after invoking the compute shader.
if (queryPool != VK_NULL_HANDLE) if (queryPool != VK_NULL_HANDLE)
vkCmdWriteTimestamp(commandBuffer, VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT, vkCmdWriteTimestamp(commandBuffer, VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT,
queryPool, 1); queryPool, 1);
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines