Added a TanOp to SPIR-V dialect GLSL ops

[georgemitenkov]

Summary

Implemented tangent op from SPIR-V's GLSL extended instruction set. Added a round-trip and
serialization/deserialization tests for the op.

[antiagainst]

Awesome, thanks George!

[NathanielMcVicar]

I believe this change broke the build on the Windows VS2017 buildbot, http://lab.llvm.org:8011/builders/mlir-windows/builds/2042. It's not obvious to me why it would generate deeply nested code. Any thoughts? Thanks!

1087.331 [396/64/2396] Building CXX object tools\mlir\lib\Dialect\SPIRV\Serialization\CMakeFiles\obj.MLIRSPIRVSerialization.dir\Serializer.cpp.obj
FAILED: tools/mlir/lib/Dialect/SPIRV/Serialization/CMakeFiles/obj.MLIRSPIRVSerialization.dir/Serializer.cpp.obj 
C:\PROGRA~2\MICROS~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=1 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\mlir\lib\Dialect\SPIRV\Serialization -IE:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\lib\Dialect\SPIRV\Serialization -Iinclude -IE:\build_slave\mlir-x64-windows-ninja\llvm-project\llvm\include -IE:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\include -Itools\mlir\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2    /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Fotools\mlir\lib\Dialect\SPIRV\Serialization\CMakeFiles\obj.MLIRSPIRVSerialization.dir\Serializer.cpp.obj /Fdtools\mlir\lib\Dialect\SPIRV\Serialization\CMakeFiles\obj.MLIRSPIRVSerialization.dir\ /FS -c E:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\lib\Dialect\SPIRV\Serialization\Serializer.cpp
tools\mlir\include\mlir/Dialect/SPIRV/SPIRVSerialization.inc(4334): fatal error C1061: compiler limit: blocks nested too deeply

mlir/include/mlir/Dialect/SPIRV/SPIRVGLSLOps.td

let description = [{
     %2 = spv.GLSL.Sin %0 : f32
     %3 = spv.GLSL.Sin %1 : vector<3xf16>
     ```
   }];
 }
 
 // -----
 
+def SPV_GLSLTanOp : SPV_GLSLUnaryArithmeticOp<"Tan", 15, SPV_Float16or32> {
+  let summary = "Tangent of operand in radians";
+
+  let description = [{
+    The standard trigonometric tangent of x radians.
+
+    The operand x must be a scalar or vector whose component type is 16-bit or 
+    32-bit floating-point.
+
+    Result Type and the type of x must be the same type. Results are computed 
+    per component.
+
+    <!-- End of AutoGen section -->
+    ```
+    restricted-float-scalar-type ::=  `f16` | `f32`
+    restricted-float-scalar-vector-type ::=
+      restricted-float-scalar-type |
+      `vector<` integer-literal `x` restricted-float-scalar-type `>`
+    tan-op ::= ssa-id `=` `spv.GLSL.Tan` ssa-use `:`
+               restricted-float-scalar-vector-type
+    ```
+    #### Example:
+
+    ```mlir
+    %2 = spv.GLSL.Tan %0 : f32
+    %3 = spv.GLSL.Tan %1 : vector<3xf16>
+    ```
+  }];
+}
+
+// -----
+
 def SPV_GLSLExpOp : SPV_GLSLUnaryArithmeticOp<"Exp", 27, SPV_Float16or32> {
   let summary = "Exponentiation of Operand 1";
 
   let description = [{
     Result is the natural exponentiation of x; e^x.
 
     The operand x must be a scalar or vector whose component type is
     16-bit or 32-bit floating-point.

mlir/test/Dialect/SPIRV/Serialization/glsl-ops.mlir

 // RUN: mlir-translate -test-spirv-roundtrip %s | FileCheck %s
 
 spv.module Logical GLSL450 requires #spv.vce<v1.0, [Shader], []> {
   spv.func @fmul(%arg0 : f32, %arg1 : f32) "None" {
     // CHECK: {{%.*}} = spv.GLSL.Exp {{%.*}} : f32
     %0 = spv.GLSL.Exp %arg0 : f32
     // CHECK: {{%.*}} = spv.GLSL.FMax {{%.*}}, {{%.*}} : f32
     %1 = spv.GLSL.FMax %arg0, %arg1 : f32
     // CHECK: {{%.*}} = spv.GLSL.Sqrt {{%.*}} : f32
     %2 = spv.GLSL.Sqrt %arg0 : f32
     // CHECK: {{%.*}} = spv.GLSL.Cos {{%.*}} : f32
     %3 = spv.GLSL.Cos %arg0 : f32
     // CHECK: {{%.*}} = spv.GLSL.Sin {{%.*}} : f32
     %4 = spv.GLSL.Sin %arg0 : f32
+    // CHECK: {{%.*}} = spv.GLSL.Tan {{%.*}} : f32
+    %5 = spv.GLSL.Tan %arg0 : f32
     spv.Return
   }
 }

mlir/test/Dialect/SPIRV/glslops.mlir

func @sin(%arg0 : f32) -> () {
   return
 }
 
 func @sinvec(%arg0 : vector<3xf16>) -> () {
   // CHECK: spv.GLSL.Sin {{%.*}} : vector<3xf16>
   %2 = spv.GLSL.Sin %arg0 : vector<3xf16>
   return
 }
+
+//===----------------------------------------------------------------------===//
+// spv.GLSL.Tan
+//===----------------------------------------------------------------------===//
+
+func @tan(%arg0 : f32) -> () {
+  // CHECK: spv.GLSL.Tan {{%.*}} : f32
+  %2 = spv.GLSL.Tan %arg0 : f32
+  return
+}
+
+func @tanvec(%arg0 : vector<3xf16>) -> () {
+  // CHECK: spv.GLSL.Tan {{%.*}} : vector<3xf16>
+  %2 = spv.GLSL.Tan %arg0 : vector<3xf16>
+  return
+}