This is an archive of the discontinued LLVM Phabricator instance.

Differential D80074

[MLIR][cmake] use LINK_LIBS PUBLIC for MLIRStandardOpsTransforms
ClosedPublic

Authored by stephenneuendorffer on May 16 2020, 10:44 PM.

Details

Reviewers
None
Commits
rGefa70843aa71: [MLIR][cmake] use LINK_LIBS PUBLIC for MLIRStandardOpsTransforms
Summary

Without this LLVM_LINK_LLVM_DYLIB is broken

Diff Detail

Event Timeline

stephenneuendorffer created this revision.May 16 2020, 10:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2020, 10:44 PM
Herald added subscribers: llvm-commits, jurahul, Kayjukh and 14 others. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.May 16 2020, 10:47 PM
Closed by commit rGefa70843aa71: [MLIR][cmake] use LINK_LIBS PUBLIC for MLIRStandardOpsTransforms (authored by stephenneuendorffer). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B56985: Diff 264472!May 16 2020, 10:48 PM

Revision Contents

PathSize
mlir/
lib/
Dialect/
StandardOps/
Transforms/
5 lines

Diff 264472

mlir/lib/Dialect/StandardOps/Transforms/CMakeLists.txt

add_mlir_dialect_library(MLIRStandardOpsTransforms add_mlir_dialect_library(MLIRStandardOpsTransforms
ExpandAtomic.cpp ExpandAtomic.cpp
FuncConversions.cpp FuncConversions.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/StandardOps/Transforms ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/StandardOps/Transforms
DEPENDS DEPENDS
MLIRStandardTransformsIncGen MLIRStandardTransformsIncGen
)
target_link_libraries(MLIRStandardOpsTransforms LINK_LIBS PUBLIC
PUBLIC
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRStandardOps MLIRStandardOps
MLIRSupport MLIRSupport
MLIRTransforms MLIRTransforms
LLVMSupport LLVMSupport
) )