This is an archive of the discontinued LLVM Phabricator instance.

Differential D80039

[NFC, StackSafety] LTO tests for MTE and StackSafety
ClosedPublic

Authored by vitalybuka on May 15 2020, 2:47 PM.

Details

Reviewers
eugenis
Commits
rG088fb9734843: [NFC, StackSafety] LTO tests for MTE and StackSafety
Summary

The test demonstrates the current state of the compiler and
I am going to resolve FIXME in followup patches.

Diff Detail

Event Timeline

vitalybuka created this revision.May 15 2020, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2020, 2:47 PM
Herald added subscribers: cfe-commits, dexonsmith, steven_wu and 2 others. · View Herald Transcript
vitalybuka updated this revision to Diff 264360.May 15 2020, 2:49 PM

remove fixme

vitalybuka updated this revision to Diff 264361.May 15 2020, 2:52 PM

comment

vitalybuka edited the summary of this revision. (Show Details)May 15 2020, 2:53 PM
Harbormaster failed remote builds in B56922: Diff 264360!May 15 2020, 3:47 PM
vitalybuka added a child revision: D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled.May 15 2020, 4:17 PM
Harbormaster failed remote builds in B56921: Diff 264358!May 15 2020, 4:19 PM
Harbormaster failed remote builds in B56923: Diff 264361!
eugenis accepted this revision.May 21 2020, 5:16 PM

LGTM, but the comments at the start of each run are confusing - they describe the desired, not the current state. Maybe move FIXME on the same line?

This revision is now accepted and ready to land.May 21 2020, 5:16 PM
Closed by commit rG088fb9734843: [NFC, StackSafety] LTO tests for MTE and StackSafety (authored by vitalybuka). · Explain WhyMay 23 2020, 6:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
test/
Driver/
143 lines

Diff 265902

clang/test/Driver/memtag_lto.c

  • This file was added.
// REQUIRES: aarch64-registered-target
// RUN: rm -f %t*
// -O1, no tagging: both are unsafe.
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -S -emit-llvm -c %s -o - | FileCheck %s
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -S -emit-llvm -c %s -o - | FileCheck %s
// Full LTO: both are unsafe.
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -c %s -flto=full -o %t.lto1.bc
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -c -DBUILD2 %s -flto=full -o %t.lto2.bc
// RUN: llvm-lto2 run -o %t.lto %t.lto1.bc %t.lto2.bc -save-temps -O1 \
// RUN: -r %t.lto1.bc,fn,plx \
// RUN: -r %t.lto1.bc,use,lx \
// RUN: -r %t.lto1.bc,use_local,plx \
// RUN: -r %t.lto1.bc,w, \
// RUN: -r %t.lto2.bc,use,plx \
// RUN: -r %t.lto2.bc,z,
// RUN: llvm-dis %t.lto.0.5.precodegen.bc -o - | FileCheck %s
// Full LTO, new PM: both are unsafe.
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -c %s -flto=full -o %t.ltonewpm1.bc
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -c -DBUILD2 %s -flto=full -o %t.ltonewpm2.bc
// RUN: llvm-lto2 run -use-new-pm -o %t.ltonewpm %t.ltonewpm1.bc %t.ltonewpm2.bc -save-temps -O1 \
// RUN: -r %t.ltonewpm1.bc,fn,plx \
// RUN: -r %t.ltonewpm1.bc,use,lx \
// RUN: -r %t.ltonewpm1.bc,use_local,plx \
// RUN: -r %t.ltonewpm1.bc,w, \
// RUN: -r %t.ltonewpm2.bc,use,plx \
// RUN: -r %t.ltonewpm2.bc,z,
// RUN: llvm-dis %t.ltonewpm.0.5.precodegen.bc -o - | FileCheck %s
// Thin LTO: both are unsafe.
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -c %s -flto=thin -o %t.thinlto1.bc
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -c -DBUILD2 %s -flto=thin -o %t.thinlto2.bc
// RUN: llvm-lto2 run -o %t.thinlto %t.thinlto1.bc %t.thinlto2.bc -save-temps -O1 \
// RUN: -r %t.thinlto1.bc,fn,plx \
// RUN: -r %t.thinlto1.bc,use,lx \
// RUN: -r %t.thinlto1.bc,use_local,plx \
// RUN: -r %t.thinlto1.bc,w, \
// RUN: -r %t.thinlto2.bc,use,plx \
// RUN: -r %t.thinlto2.bc,z,
// RUN: llvm-dis %t.thinlto.1.5.precodegen.bc -o - | FileCheck %s
// Thin LTO, new PM: both are unsafe.
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -c %s -flto=thin -o %t.thinltonewpm1.bc
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -c -DBUILD2 %s -flto=thin -o %t.thinltonewpm2.bc
// RUN: llvm-lto2 run -use-new-pm -o %t.thinltonewpm %t.thinltonewpm1.bc %t.thinltonewpm2.bc -save-temps -O1 \
// RUN: -r %t.thinltonewpm1.bc,fn,plx \
// RUN: -r %t.thinltonewpm1.bc,use,lx \
// RUN: -r %t.thinltonewpm1.bc,use_local,plx \
// RUN: -r %t.thinltonewpm1.bc,w, \
// RUN: -r %t.thinltonewpm2.bc,use,plx \
// RUN: -r %t.thinltonewpm2.bc,z,
// RUN: llvm-dis %t.thinltonewpm.1.5.precodegen.bc -o - | FileCheck %s
// Now with MTE.
// RUN: rm -f %t*
// -O0: both are unsafe.
// RUN: %clang -fno-experimental-new-pass-manager -O0 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -S -emit-llvm -c %s -o - | FileCheck %s
// RUN: %clang -fexperimental-new-pass-manager -O0 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -S -emit-llvm -c %s -o - | FileCheck %s
// No LTO: just one is safe.
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -S -emit-llvm -c %s -o - | FileCheck %s -check-prefixes=XUNSAFE,YSAFE
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -S -emit-llvm -c %s -o - | FileCheck %s -check-prefixes=XUNSAFE,YSAFE
// FIXME: Full LTO: both are safe.
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -c %s -flto=full -o %t.lto1.bc
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -c -DBUILD2 %s -flto=full -o %t.lto2.bc
// RUN: llvm-lto2 run -o %t.lto %t.lto1.bc %t.lto2.bc -save-temps -O1 \
// RUN: -r %t.lto1.bc,fn,plx \
// RUN: -r %t.lto1.bc,use,lx \
// RUN: -r %t.lto1.bc,use_local,plx \
// RUN: -r %t.lto1.bc,w, \
// RUN: -r %t.lto2.bc,use,plx \
// RUN: -r %t.lto2.bc,z,
// RUN: llvm-dis %t.lto.0.5.precodegen.bc -o - | FileCheck %s -check-prefixes=XUNSAFE,YSAFE
// FIXME: Full LTO, new PM: both are safe.
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -c %s -flto=full -o %t.ltonewpm1.bc
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -c -DBUILD2 %s -flto=full -o %t.ltonewpm2.bc
// RUN: llvm-lto2 run -use-new-pm -o %t.ltonewpm %t.ltonewpm1.bc %t.ltonewpm2.bc -save-temps -O1 \
// RUN: -r %t.ltonewpm1.bc,fn,plx \
// RUN: -r %t.ltonewpm1.bc,use,lx \
// RUN: -r %t.ltonewpm1.bc,use_local,plx \
// RUN: -r %t.ltonewpm1.bc,w, \
// RUN: -r %t.ltonewpm2.bc,use,plx \
// RUN: -r %t.ltonewpm2.bc,z,
// RUN: llvm-dis %t.ltonewpm.0.5.precodegen.bc -o - | FileCheck %s -check-prefixes=XUNSAFE,YSAFE
// FIXME: Thin LTO: both are safe.
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -c %s -flto=thin -o %t.thinlto1.bc
// RUN: %clang -fno-experimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -c -DBUILD2 %s -flto=thin -o %t.thinlto2.bc
// RUN: llvm-lto2 run -o %t.thinlto %t.thinlto1.bc %t.thinlto2.bc -save-temps -O1 \
// RUN: -r %t.thinlto1.bc,fn,plx \
// RUN: -r %t.thinlto1.bc,use,lx \
// RUN: -r %t.thinlto1.bc,use_local,plx \
// RUN: -r %t.thinlto1.bc,w, \
// RUN: -r %t.thinlto2.bc,use,plx \
// RUN: -r %t.thinlto2.bc,z,
// RUN: llvm-dis %t.thinlto.1.5.precodegen.bc -o - | FileCheck %s -check-prefixes=XUNSAFE,YSAFE
// FIXME: Thin LTO, new PM: both are safe.
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -c %s -flto=thin -o %t.thinltonewpm1.bc
// RUN: %clang -fexperimental-new-pass-manager -O1 -target aarch64-unknown-linux -march=armv8+memtag -fsanitize=memtag -c -DBUILD2 %s -flto=thin -o %t.thinltonewpm2.bc
// RUN: llvm-lto2 run -use-new-pm -o %t.thinltonewpm %t.thinltonewpm1.bc %t.thinltonewpm2.bc -save-temps -O1 \
// RUN: -r %t.thinltonewpm1.bc,fn,plx \
// RUN: -r %t.thinltonewpm1.bc,use,lx \
// RUN: -r %t.thinltonewpm1.bc,use_local,plx \
// RUN: -r %t.thinltonewpm1.bc,w, \
// RUN: -r %t.thinltonewpm2.bc,use,plx \
// RUN: -r %t.thinltonewpm2.bc,z,
// RUN: llvm-dis %t.thinltonewpm.1.5.precodegen.bc -o - | FileCheck %s -check-prefixes=XUNSAFE,YSAFE
void use(int *p);
#ifdef BUILD2
int z;
__attribute__((noinline)) void use(int *p) { *p = z; }
#else
char w;
__attribute__((noinline)) void use_local(char *p) { *p = w; }
__attribute__((visibility("default"))) int fn() {
// XUNSAFE: alloca i32, align 4{{$}}
// XSAFE: alloca i32, align 4, !stack-safe
int x;
use(&x);
// YUNSAFE-NEXT: alloca i8, align 4{{$}}
// YSAFE-NEXT: alloca i8, align 4, !stack-safe
char y;
use_local(&y);
return x + y;
}
// CHECK-NOT: !stack-safe
#endif