This is an archive of the discontinued LLVM Phabricator instance.

Differential D79897

Only run pretty-printer tests for builds with debug-info.
ClosedPublic

Authored by csigg on May 13 2020, 11:51 AM.

Details

Reviewers
dblaikie
Commits
rG104e38cf761e: Only run pretty-printer tests for builds with debug-info.

Diff Detail

Event Timeline

csigg created this revision.May 13 2020, 11:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2020, 11:51 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
csigg updated this revision to Diff 263827.May 13 2020, 12:48 PM

Adding 'debug-info' feature config because assert does not necessarily imply debug info.

csigg updated this revision to Diff 263828.May 13 2020, 12:51 PM

Undo formatting.

csigg updated this revision to Diff 263829.May 13 2020, 12:53 PM

Really undo formatting.

csigg retitled this revision from Only run pretty-printer tests for debug builds. to Only run pretty-printer tests for builds with debug-info..May 13 2020, 12:54 PM
csigg added a reviewer: dblaikie.
Harbormaster completed remote builds in B56641: Diff 263808.May 13 2020, 2:10 PM
dblaikie accepted this revision.May 13 2020, 3:01 PM

Sounds good, thanks!

This revision is now accepted and ready to land.May 13 2020, 3:01 PM
Harbormaster completed remote builds in B56653: Diff 263827.May 13 2020, 3:51 PM
Harbormaster completed remote builds in B56655: Diff 263829.May 13 2020, 4:24 PM
Harbormaster completed remote builds in B56654: Diff 263828.
tbosch added a subscriber: tbosch.May 13 2020, 5:01 PM

Nice, this fixes https://bugs.llvm.org/show_bug.cgi?id=45652

Closed by commit rG104e38cf761e: Only run pretty-printer tests for builds with debug-info. (authored by csigg). · Explain WhyMay 14 2020, 12:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
debuginfo-tests/
3 lines
llvm-prettyprinters/
gdb/
1 line

Diff 263829

debuginfo-tests/lit.cfg.py

Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Linesif platform.system() == 'Darwin':
import subprocess import subprocess
xcode_lldb_vers = subprocess.check_output(['xcrun', 'lldb', '--version']).decode("utf-8") xcode_lldb_vers = subprocess.check_output(['xcrun', 'lldb', '--version']).decode("utf-8")
match = re.search('lldb-(\d+)', xcode_lldb_vers) match = re.search('lldb-(\d+)', xcode_lldb_vers)
if match: if match:
apple_lldb_vers = int(match.group(1)) apple_lldb_vers = int(match.group(1))
if apple_lldb_vers < 1000: if apple_lldb_vers < 1000:
config.available_features.add('apple-lldb-pre-1000') config.available_features.add('apple-lldb-pre-1000')
llvm_config.feature_config([('--build-mode', {
'Debug|RelWithDebInfo': 'debug-info'
})])

debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.gdb

# RUN: gdb -q -batch -n -iex 'source %llvm_src_root/utils/gdb-scripts/prettyprinters.py' -x %s %llvm_tools_dir/check-gdb-llvm-support | FileCheck %s --dump-input-on-failure # RUN: gdb -q -batch -n -iex 'source %llvm_src_root/utils/gdb-scripts/prettyprinters.py' -x %s %llvm_tools_dir/check-gdb-llvm-support | FileCheck %s --dump-input-on-failure
# REQUIRES: debug-info
break main break main
run run
# CHECK: llvm::ArrayRef of length 3 = {1, 2, 3} # CHECK: llvm::ArrayRef of length 3 = {1, 2, 3}
p ArrayRef p ArrayRef
# CHECK: llvm::ArrayRef of length 3 = {1, 2, 3} # CHECK: llvm::ArrayRef of length 3 = {1, 2, 3}
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines