This is an archive of the discontinued LLVM Phabricator instance.

Differential D79667

[Clang] Pass -z max-page-size to linker for Fuchsia
ClosedPublic

Authored by mcgrathr on May 9 2020, 2:09 AM.

Details

Reviewers
phosek
Commits
rG5b02be0b973a: [Clang] Pass -z max-page-size to linker for Fuchsia
Summary

Currently all Fuchsia ABIs use a 4k page size, departing from
the recommended page sizes in the respective psABI documents.

Diff Detail

Event Timeline

mcgrathr created this revision.May 9 2020, 2:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2020, 2:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mcgrathr added a parent revision: D79665: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia.May 9 2020, 2:10 AM
Harbormaster completed remote builds in B56223: Diff 263004.May 9 2020, 3:41 AM
phosek accepted this revision.May 9 2020, 1:45 PM

LGTM

This revision is now accepted and ready to land.May 9 2020, 1:45 PM
Closed by commit rG5b02be0b973a: [Clang] Pass -z max-page-size to linker for Fuchsia (authored by phosek). · Explain WhyMay 9 2020, 1:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
3 lines
test/
Driver/
2 lines

Diff 263004

clang/lib/Driver/ToolChains/Fuchsia.cpp

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Linesvoid fuchsia::Linker::ConstructJob(Compilation &C, const JobAction &JA,
Args.ClaimAllArgs(options::OPT_g_Group); Args.ClaimAllArgs(options::OPT_g_Group);
// and "clang -emit-llvm foo.o -o foo" // and "clang -emit-llvm foo.o -o foo"
Args.ClaimAllArgs(options::OPT_emit_llvm); Args.ClaimAllArgs(options::OPT_emit_llvm);
// and for "clang -w foo.o -o foo". Other warning options are already // and for "clang -w foo.o -o foo". Other warning options are already
// handled somewhere else. // handled somewhere else.
Args.ClaimAllArgs(options::OPT_w); Args.ClaimAllArgs(options::OPT_w);
CmdArgs.push_back("-z"); CmdArgs.push_back("-z");
CmdArgs.push_back("max-page-size=4096");
CmdArgs.push_back("-z");
CmdArgs.push_back("now"); CmdArgs.push_back("now");
const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath()); const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
if (llvm::sys::path::filename(Exec).equals_lower("ld.lld") || if (llvm::sys::path::filename(Exec).equals_lower("ld.lld") ||
llvm::sys::path::stem(Exec).equals_lower("ld.lld")) { llvm::sys::path::stem(Exec).equals_lower("ld.lld")) {
CmdArgs.push_back("-z"); CmdArgs.push_back("-z");
CmdArgs.push_back("rodynamic"); CmdArgs.push_back("rodynamic");
CmdArgs.push_back("-z"); CmdArgs.push_back("-z");
▲ Show 20 Lines • Show All 307 Lines • Show Last 20 Lines

clang/test/Driver/fuchsia.c

Show All 17 Lines
// CHECK: "-munwind-tables" // CHECK: "-munwind-tables"
// CHECK: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
// CHECK: "-isysroot" "[[SYSROOT:[^"]+]]" // CHECK: "-isysroot" "[[SYSROOT:[^"]+]]"
// CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include" // CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include"
// CHECK-AARCH64: "-fsanitize=shadow-call-stack" // CHECK-AARCH64: "-fsanitize=shadow-call-stack"
// CHECK-X86_64: "-fsanitize=safe-stack" // CHECK-X86_64: "-fsanitize=safe-stack"
// CHECK: "-stack-protector" "2" // CHECK: "-stack-protector" "2"
// CHECK-NOT: "-fcommon" // CHECK-NOT: "-fcommon"
// CHECK: {{.*}}ld.lld{{.*}}" "-z" "now" "-z" "rodynamic" "-z" "separate-loadable-segments" "--pack-dyn-relocs=relr" // CHECK: {{.*}}ld.lld{{.*}}" "-z" "max-page-size=4096" "-z" "now" "-z" "rodynamic" "-z" "separate-loadable-segments" "--pack-dyn-relocs=relr"
// CHECK: "--sysroot=[[SYSROOT]]" // CHECK: "--sysroot=[[SYSROOT]]"
// CHECK: "-pie" // CHECK: "-pie"
// CHECK: "--build-id" // CHECK: "--build-id"
// CHECK: "--hash-style=gnu" // CHECK: "--hash-style=gnu"
// CHECK: "-dynamic-linker" "ld.so.1" // CHECK: "-dynamic-linker" "ld.so.1"
// CHECK: Scrt1.o // CHECK: Scrt1.o
// CHECK-NOT: crti.o // CHECK-NOT: crti.o
// CHECK-NOT: crtbegin.o // CHECK-NOT: crtbegin.o
▲ Show 20 Lines • Show All 210 Lines • Show Last 20 Lines