This is an archive of the discontinued LLVM Phabricator instance.

Differential D79665

[Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia
ClosedPublic

Authored by mcgrathr on May 9 2020, 1:54 AM.

Details

Reviewers
phosek
Commits
rGc8fbcb1e78ad: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia
Summary

The compact format is fully supported on Fuchsia and is the
preferred default.

Diff Detail

Event Timeline

mcgrathr created this revision.May 9 2020, 1:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2020, 1:54 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mcgrathr added a child revision: D79667: [Clang] Pass -z max-page-size to linker for Fuchsia.May 9 2020, 2:10 AM
Harbormaster completed remote builds in B56222: Diff 263001.May 9 2020, 3:09 AM
phosek accepted this revision.May 9 2020, 1:42 PM

LGTM

This revision is now accepted and ready to land.May 9 2020, 1:42 PM
Closed by commit rGc8fbcb1e78ad: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia (authored by phosek). · Explain WhyMay 9 2020, 1:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
1 line
test/
Driver/
2 lines

Diff 263036

clang/lib/Driver/ToolChains/Fuchsia.cpp

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Linesvoid fuchsia::Linker::ConstructJob(Compilation &C, const JobAction &JA,
const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath()); const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
if (llvm::sys::path::filename(Exec).equals_lower("ld.lld") || if (llvm::sys::path::filename(Exec).equals_lower("ld.lld") ||
llvm::sys::path::stem(Exec).equals_lower("ld.lld")) { llvm::sys::path::stem(Exec).equals_lower("ld.lld")) {
CmdArgs.push_back("-z"); CmdArgs.push_back("-z");
CmdArgs.push_back("rodynamic"); CmdArgs.push_back("rodynamic");
CmdArgs.push_back("-z"); CmdArgs.push_back("-z");
CmdArgs.push_back("separate-loadable-segments"); CmdArgs.push_back("separate-loadable-segments");
CmdArgs.push_back("--pack-dyn-relocs=relr");
} }
if (!D.SysRoot.empty()) if (!D.SysRoot.empty())
CmdArgs.push_back(Args.MakeArgString("--sysroot=" + D.SysRoot)); CmdArgs.push_back(Args.MakeArgString("--sysroot=" + D.SysRoot));
if (!Args.hasArg(options::OPT_shared) && !Args.hasArg(options::OPT_r)) if (!Args.hasArg(options::OPT_shared) && !Args.hasArg(options::OPT_r))
CmdArgs.push_back("-pie"); CmdArgs.push_back("-pie");
▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines

clang/test/Driver/fuchsia.c

Show All 17 Lines
// CHECK: "-munwind-tables" // CHECK: "-munwind-tables"
// CHECK: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
// CHECK: "-isysroot" "[[SYSROOT:[^"]+]]" // CHECK: "-isysroot" "[[SYSROOT:[^"]+]]"
// CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include" // CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include"
// CHECK-AARCH64: "-fsanitize=shadow-call-stack" // CHECK-AARCH64: "-fsanitize=shadow-call-stack"
// CHECK-X86_64: "-fsanitize=safe-stack" // CHECK-X86_64: "-fsanitize=safe-stack"
// CHECK: "-stack-protector" "2" // CHECK: "-stack-protector" "2"
// CHECK-NOT: "-fcommon" // CHECK-NOT: "-fcommon"
// CHECK: {{.*}}ld.lld{{.*}}" "-z" "now" "-z" "rodynamic" "-z" "separate-loadable-segments" // CHECK: {{.*}}ld.lld{{.*}}" "-z" "now" "-z" "rodynamic" "-z" "separate-loadable-segments" "--pack-dyn-relocs=relr"
// CHECK: "--sysroot=[[SYSROOT]]" // CHECK: "--sysroot=[[SYSROOT]]"
// CHECK: "-pie" // CHECK: "-pie"
// CHECK: "--build-id" // CHECK: "--build-id"
// CHECK: "--hash-style=gnu" // CHECK: "--hash-style=gnu"
// CHECK: "-dynamic-linker" "ld.so.1" // CHECK: "-dynamic-linker" "ld.so.1"
// CHECK: Scrt1.o // CHECK: Scrt1.o
// CHECK-NOT: crti.o // CHECK-NOT: crti.o
// CHECK-NOT: crtbegin.o // CHECK-NOT: crtbegin.o
▲ Show 20 Lines • Show All 210 Lines • Show Last 20 Lines