This is an archive of the discontinued LLVM Phabricator instance.

Fix ShapeBase.td
ClosedPublic

Authored by silvas on May 6 2020, 10:38 AM.

Details

Summary
  • Add license header.
  • Remove TODO about extracting ShapeBase.td

Diff Detail

Event Timeline

silvas created this revision.May 6 2020, 10:38 AM
Herald added a project: Restricted Project. · View Herald Transcript
jpienaar accepted this revision.May 6 2020, 10:41 AM

Looks good with the comment about file's purpose updated.

mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td
10

This file seems to contain the dialect definition and types instead (e.g., there are no operations in here).

This revision is now accepted and ready to land.May 6 2020, 10:41 AM
silvas marked an inline comment as done.May 6 2020, 10:42 AM
This revision was automatically updated to reflect the committed changes.