This is an archive of the discontinued LLVM Phabricator instance.

[amdgpu] Fix check of VCC.
ClosedPublic

Authored by hliao on May 6 2020, 8:40 AM.

Details

Summary
  • Need to include checking on the new 16-bit subregs.

Diff Detail

Event Timeline

hliao created this revision.May 6 2020, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2020, 8:40 AM
hliao added a comment.May 6 2020, 8:43 AM

One alternative is to check isSuperRegisterEq(Reg, VCC) for conciseness and readability. Not sure, we will have similar issues on other special registers with 16-bit subregs. But, I admit that's costy compared to the current switch.

rampitec accepted this revision.May 6 2020, 9:10 AM

LGTM, thanks.

This revision is now accepted and ready to land.May 6 2020, 9:10 AM
This revision was automatically updated to reflect the committed changes.