This is an archive of the discontinued LLVM Phabricator instance.

Differential D7948

Fix failing tests caused by lack of default debug info
ClosedPublic

Authored by vharron on Feb 27 2015, 11:30 AM.

Details

Reviewers
sivachandra
ovyalov
clayborg
Summary

Linux clang 3.5+ doesn't have full debug info by default. This
change ensures that there is enough debug info for the tests to pass.

Fixes the following tests:

TestCallStdStringFunction.py
TestDataFormatterSkipSummary.py
TestDataFormatterStdIterator.py
TestDataFormatterStdList.py
TestDataFormatterStdString.py
TestSBValuePersist.py
TestStringPrinter.py
TestTypeCompletion.py

Also modified expectedFailureClang to accept compiler version like
expectedFailureGcc

Diff Detail

Event Timeline

vharron updated this revision to Diff 20872.Feb 27 2015, 11:30 AM
vharron retitled this revision from to Fix failing tests caused by lack of default debug info.
vharron updated this object.
vharron edited the test plan for this revision. (Show Details)
vharron added reviewers: clayborg, ovyalov, sivachandra.
vharron added a subscriber: Unknown Object (MLST).
rnk added a subscriber: rnk.Feb 27 2015, 11:42 AM

It seems reasonable to tweak the tests to keep them green, but eventually we need to resolve this in LLDB.

sivachandra accepted this revision.Feb 27 2015, 12:47 PM
sivachandra edited edge metadata.

LGTM.

What I would really love to see is more descriptive commit message headers which are not one-line monsters. Most definitely up to you, but how about

"Use -fstandalone-debug for few tests to get around a Clang optimization."

test/lldbtest.py
560

Up to you, but this should probably be a different change, in line with my subject line suggestion.

This revision is now accepted and ready to land.Feb 27 2015, 12:47 PM
sivachandra added a comment.Feb 27 2015, 12:51 PM

With reference to rnk's comment: "... but eventually we need to resolve this in LLDB"

All that I see in the DWARF generated by clang-3.5 is this:

< 2><0x00000037> DW_TAG_class_type

DW_AT_name                  "basic_string<char, std::char_traits<char>, std::allocator<char> >"
DW_AT_declaration           yes(1)

In which case, what can LLDB do?

vharron added a comment.Feb 27 2015, 1:09 PM

They've suggested using the debug info from the libstdc++'s symbol file.

clayborg accepted this revision.Feb 27 2015, 1:19 PM
clayborg edited edge metadata.

Looks good, but we should document this with a more descriptive comments.

vharron closed this revision.Feb 27 2015, 5:21 PM

Committed r230831

Per Greg's request, updated comments as follows: (please let me known if this isn't what you had in mind)

+# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
+# targets. Other targets do not, which causes this test to fail.
+# This flag enables FullDebugInfo for all targets.
+ifneq (,$(findstring clang,$(CC)))
+ CFLAGS_EXTRAS := -fstandalone-debug
+endif

Commit comment (Siva's request)

Use -fstandalone-debug for few tests to get around a Clang optimization

clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD targets.
Other targets do not, which causes several tests to fail. This flag
enables FullDebugInfo for all targets.

Fixes the following tests:

TestCallStdStringFunction.py
TestDataFormatterSkipSummary.py
TestDataFormatterStdIterator.py
TestDataFormatterStdList.py
TestDataFormatterStdString.py
TestSBValuePersist.py
TestStringPrinter.py
TestTypeCompletion.py

sivachandra added a comment.Feb 27 2015, 5:27 PM

Thanks for changing the commit message.

Revision Contents

PathSize
test/
expression_command/
call-function/
5 lines
functionalities/
data-formatter/
data-formatter-skip-summary/
5 lines
data-formatter-stl/
libstdcpp/
iterator/
5 lines
list/
5 lines
string/
5 lines
data-formatter-synth/
5 lines
rdar-9974002/
5 lines
stringprinter/
6 lines
type_completion/
5 lines
lang/
cpp/
stl/
5 lines
4 lines
python_api/
sbvalue_persist/
5 lines

Diff 20872

test/expression_command/call-function/Makefile

LEVEL = ../../make LEVEL = ../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
clean:: clean::
rm -rf *.o *.d *.dSYM rm -rf *.o *.d *.dSYM

test/functionalities/data-formatter/data-formatter-skip-summary/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
CXXFLAGS += -O0 CXXFLAGS += -O0
ifeq (,$(findstring gcc,$(CC))) ifeq (,$(findstring gcc,$(CC)))
CXXFLAGS += -stdlib=libstdc++ CXXFLAGS += -stdlib=libstdc++
LDFLAGS += -stdlib=libstdc++ LDFLAGS += -stdlib=libstdc++
endif endif

test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS_EXTRAS := -O0 CFLAGS_EXTRAS := -O0
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS_EXTRAS := -O0 CFLAGS_EXTRAS := -O0
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile

LEVEL = ../../../../../make LEVEL = ../../../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS_EXTRAS := -O0 CFLAGS_EXTRAS := -O0
USE_LIBSTDCPP := 1 USE_LIBSTDCPP := 1
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

test/functionalities/data-formatter/data-formatter-synth/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

test/functionalities/data-formatter/rdar-9974002/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

test/functionalities/data-formatter/stringprinter/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CXXFLAGS += -std=c++11 CXXFLAGS += -std=c++11
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

test/functionalities/type_completion/Makefile

LEVEL = ../../make LEVEL = ../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

test/lang/cpp/stl/Makefile

LEVEL = ../../../make LEVEL = ../../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS := -g -O0 CFLAGS := -g -O0
clean: OBJECTS+=$(wildcard main.d.*) clean: OBJECTS+=$(wildcard main.d.*)
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules

test/lldbtest.py

Show First 20 Lines • Show All 550 Lines • ▼ Show 20 Lines
def expectedFailureCompiler(compiler, compiler_version=None, bugnumber=None): def expectedFailureCompiler(compiler, compiler_version=None, bugnumber=None):
if compiler_version is None: if compiler_version is None:
compiler_version=['=', None] compiler_version=['=', None]
def fn(self): def fn(self):
return compiler in self.getCompiler() and self.expectedCompilerVersion(compiler_version) return compiler in self.getCompiler() and self.expectedCompilerVersion(compiler_version)
if bugnumber: return expectedFailure(fn, bugnumber) if bugnumber: return expectedFailure(fn, bugnumber)
def expectedFailureClang(bugnumber=None): def expectedFailureClang(bugnumber=None, compiler_version=None):
if bugnumber: return expectedFailureCompiler('clang', None, bugnumber) if bugnumber: return expectedFailureCompiler('clang', compiler_version, bugnumber)
sivachandraUnsubmitted
Not Done
ReplyInline Actions

Up to you, but this should probably be a different change, in line with my subject line suggestion.

sivachandra: Up to you, but this should probably be a different change, in line with my subject line…
def expectedFailureGcc(bugnumber=None, compiler_version=None): def expectedFailureGcc(bugnumber=None, compiler_version=None):
if bugnumber: return expectedFailureCompiler('gcc', compiler_version, bugnumber) if bugnumber: return expectedFailureCompiler('gcc', compiler_version, bugnumber)
def expectedFailureIcc(bugnumber=None): def expectedFailureIcc(bugnumber=None):
if bugnumber: return expectedFailureCompiler('icc', None, bugnumber) if bugnumber: return expectedFailureCompiler('icc', None, bugnumber)
def expectedFailureArch(arch, bugnumber=None): def expectedFailureArch(arch, bugnumber=None):
▲ Show 20 Lines • Show All 1,589 Lines • Show Last 20 Lines

test/python_api/sbvalue_persist/Makefile

LEVEL = ../../make LEVEL = ../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# Clean renamed executable on 'make clean' # Clean renamed executable on 'make clean'
clean: OBJECTS+=no_synth clean: OBJECTS+=no_synth
# debug info is needed for std::string print
ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug
endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules