Page MenuHomePhabricator

vharron (Vince Harron)
Engineering Manager

Projects

User does not belong to any projects.

User Details

User Since
Oct 20 2014, 3:01 PM (268 w, 4 d)

I run the new Android C/C++/GPU Developer Tools teams at Google.

Recent Activity

Dec 6 2017

vharron created D40930: Don't add a dependency on the backtrace library if it can't be found..
Dec 6 2017, 4:29 PM

Jul 1 2015

vharron added a comment to D10888: Change executable name to a.out..

Spectacular speech to text failure

Jul 1 2015, 8:12 PM
vharron added a comment to D10888: Change executable name to a.out..

Does the LoL DB API output a clear and actionable error code if the
filename you are launching is too long? If not please add a test for this

Jul 1 2015, 8:11 PM

Jun 29 2015

vharron added a comment to D10830: Ignore teardown failure if it's caused by removing missing file or directory.

Maybe we should call teardown from expectedFlakey instead?

Jun 29 2015, 9:09 PM
vharron added a comment to D10800: Fix [vdso] handling on Android (x86 and aarch64).

You can use the gdb remote get auxv command I think to get libvdso load
address.

Jun 29 2015, 4:15 PM
vharron added a comment to D10800: Fix [vdso] handling on Android (x86 and aarch64).

If you've fixed vdso handling, shouldn't some i386 tests be marked as passing?

Jun 29 2015, 1:25 PM

Jun 26 2015

vharron abandoned D9859: Removed XFAIL from TestExitDuringBreak.
Jun 26 2015, 9:15 PM
vharron added a comment to D10787: Replace `rm -rf` with more portable implementation..

LGTM

Jun 26 2015, 8:33 PM
vharron accepted D10778: timegm in LibcGlue needs to be extern, not static..
Jun 26 2015, 8:33 PM
vharron committed rL240803: Fixed incorrect application of expectedFlakey.
Fixed incorrect application of expectedFlakey
Jun 26 2015, 11:01 AM
vharron committed rL240789: Added expectedFlakey test decorator.
Added expectedFlakey test decorator
Jun 26 2015, 8:13 AM
vharron closed D10721: Added expectedFlakey test decorator by committing rL240789: Added expectedFlakey test decorator.
Jun 26 2015, 8:13 AM

Jun 25 2015

vharron updated the diff for D10721: Added expectedFlakey test decorator.

Added expectedFlakeyClang/Gcc, switched a bunch of tests to use new decorator.

Jun 25 2015, 10:28 PM

Jun 24 2015

vharron retitled D10721: Added expectedFlakey test decorator from to Added expectedFlakey test decorator.
Jun 24 2015, 5:51 PM

Jun 22 2015

vharron committed rL240327: Adding some more flakey tests to the XFAIL list.
Adding some more flakey tests to the XFAIL list
Jun 22 2015, 1:58 PM
vharron added a comment to D10583: Adding some more flakey tests to the XFAIL list.

Logs sent directly to Ilia

Jun 22 2015, 8:14 AM

Jun 19 2015

vharron added a comment to D10509: Don't crash if a member declaration is incomplete.

Ah, if clang-3.6 is on your path try -C clang-3.6 instead of /usr/bin/cc

Jun 19 2015, 7:44 PM
vharron added a comment to D10509: Don't crash if a member declaration is incomplete.

The test suite appears to be failing because it's failing to find a suitable compiler. Try to

Jun 19 2015, 6:04 PM
vharron added a reviewer for D10583: Adding some more flakey tests to the XFAIL list: ki.stfu.
Jun 19 2015, 6:00 PM
vharron retitled D10583: Adding some more flakey tests to the XFAIL list from to Adding some more flakey tests to the XFAIL list.
Jun 19 2015, 5:56 PM
vharron added a comment to D10509: Don't crash if a member declaration is incomplete.

Hi Keno,

Jun 19 2015, 6:17 AM

Jun 17 2015

vharron added a comment to D10527: dosep.py: Add ability to set default test timout based on target.

Do remote tests pass in this time range? If not, maybe you should change
it to use 10 minutes for remote targets.

Jun 17 2015, 7:12 PM

Jun 1 2015

vharron added a comment to D10085: Add Read Thread to GDBRemoteCommunication. .

Ewan, has your non-stop mode implementation been tested against gdbserver?

Jun 1 2015, 9:31 PM

May 31 2015

vharron requested changes to D10085: Add Read Thread to GDBRemoteCommunication. .

Hi Ewan,

May 31 2015, 11:06 AM

May 28 2015

vharron added a comment to D10085: Add Read Thread to GDBRemoteCommunication. .

Hi Ewan,

May 28 2015, 9:06 AM

May 26 2015

vharron closed D9957: www - updated build server URLs.
May 26 2015, 9:59 PM
vharron committed rL238284: www - updated build server URLs.
www - updated build server URLs
May 26 2015, 9:59 PM
vharron added a comment to D9957: www - updated build server URLs.

238284

May 26 2015, 9:59 PM
vharron committed rL238283: Changed Flags::clang_type_resolve_state to unsigned for gcc.
Changed Flags::clang_type_resolve_state to unsigned for gcc
May 26 2015, 9:58 PM
vharron closed D9950: Changed ResolveState to unsigned to work around noisy gcc warning.

238283

May 26 2015, 9:58 PM
vharron closed D9937: dotest.py - fixed a bug displaying usage.
May 26 2015, 9:47 PM
vharron committed rL238282: test Makefile.rules - pick a more sensible default CC on Linux.
test Makefile.rules - pick a more sensible default CC on Linux
May 26 2015, 9:46 PM
vharron closed D9920: test Makefile.rules - pick a more sensible default CC on Linux by committing rL238282: test Makefile.rules - pick a more sensible default CC on Linux.
May 26 2015, 9:46 PM
vharron committed rL238281: dosep - force timeout processes to dump core when they timeout.
dosep - force timeout processes to dump core when they timeout
May 26 2015, 9:44 PM
vharron closed D9905: dosep - force timeout processes to dump core when they timeout by committing rL238281: dosep - force timeout processes to dump core when they timeout.
May 26 2015, 9:44 PM
vharron accepted D9876: Make log options uniform between lldb-platform and lldb-gdbserver.
May 26 2015, 6:14 PM
vharron added inline comments to D9902: Link against installed library when running lldb test with gcc-4.9.2.
May 26 2015, 3:59 PM

May 25 2015

vharron closed D9965: Print port number that lldb-server binds to in platform mode.

r238173

May 25 2015, 8:20 PM
vharron added a comment to D9953: Send email notification for failures on lldb android builder.

Sorry, I mean

May 25 2015, 8:19 PM
vharron requested changes to D9953: Send email notification for failures on lldb android builder.
May 25 2015, 8:17 PM
vharron committed rL238174: revert files unintentionally checked in.
revert files unintentionally checked in
May 25 2015, 8:14 PM
vharron committed rL238173: Print port number that lldb-server binds to in platform mode.
Print port number that lldb-server binds to in platform mode
May 25 2015, 8:11 PM

May 24 2015

vharron retitled D9965: Print port number that lldb-server binds to in platform mode from to Print port number that lldb-server binds to in platform mode.
May 24 2015, 7:35 PM
vharron added a comment to D9884: Remove log2 dependency when building against Android API-9 SDK.

I needed this patch so I was able to verify and submit. Thanks Pierre-Andre!

May 24 2015, 6:30 AM
vharron committed rL238111: Remove log2 dependency when building against Android API-9 SDK.
Remove log2 dependency when building against Android API-9 SDK
May 24 2015, 6:28 AM
vharron closed D9884: Remove log2 dependency when building against Android API-9 SDK by committing rL238111: Remove log2 dependency when building against Android API-9 SDK.
May 24 2015, 6:28 AM

May 23 2015

vharron retitled D9957: www - updated build server URLs from to www - updated build server URLs.
May 23 2015, 3:57 PM
vharron added a comment to D9950: Changed ResolveState to unsigned to work around noisy gcc warning.

I will change this to only use "unsigned" type when compiled with gcc.

May 23 2015, 2:32 PM

May 22 2015

vharron retitled D9950: Changed ResolveState to unsigned to work around noisy gcc warning from to Changed ResolveState to unsigned to work around noisy gcc warning.
May 22 2015, 4:05 PM
vharron added a comment to D9948: [TestBase.runCmd] Better error message when runCmd fails..

I removed my approval, waiting for feedback from others.

May 22 2015, 3:50 PM
vharron removed a reviewer for D9948: [TestBase.runCmd] Better error message when runCmd fails.: vharron.
May 22 2015, 3:49 PM
vharron accepted D9948: [TestBase.runCmd] Better error message when runCmd fails..
May 22 2015, 3:49 PM
vharron added a reviewer for D9948: [TestBase.runCmd] Better error message when runCmd fails.: vharron.
May 22 2015, 3:49 PM
vharron accepted D9857: Use target's SIGSTOP and SIGINT when making decision about continue after async packet..
May 22 2015, 3:27 PM
vharron committed rL238043: dotest.py - fixed a bug displaying usage.
dotest.py - fixed a bug displaying usage
May 22 2015, 12:53 PM
vharron retitled D9937: dotest.py - fixed a bug displaying usage from to dotest.py - fixed a bug displaying usage.
May 22 2015, 7:54 AM

May 21 2015

vharron updated the diff for D9920: test Makefile.rules - pick a more sensible default CC on Linux.

Removed Makefile

May 21 2015, 2:58 PM
vharron retitled D9920: test Makefile.rules - pick a more sensible default CC on Linux from to test Makefile.rules - pick a more sensible default CC on Linux.
May 21 2015, 2:57 PM
vharron added a comment to D9868: dotest.py - debug feature that helps find dosep races.

I'll add a command line parameter in a followup CL (when we suspect this is a problem again)

May 21 2015, 12:14 PM
vharron committed rL237935: dotest.py - debug feature that helps find dosep races.
dotest.py - debug feature that helps find dosep races
May 21 2015, 12:13 PM
vharron closed D9868: dotest.py - debug feature that helps find dosep races by committing rL237935: dotest.py - debug feature that helps find dosep races.
May 21 2015, 12:13 PM
vharron committed rL237933: XPASS a bunch of GdbRemote/LldbGdbServer tests.
XPASS a bunch of GdbRemote/LldbGdbServer tests
May 21 2015, 11:59 AM
vharron closed D9892: XPASS a bunch of GdbRemote/LldbGdbServer tests by committing rL237933: XPASS a bunch of GdbRemote/LldbGdbServer tests.
May 21 2015, 11:59 AM
vharron committed rL237932: Fixed intermittent failures in TestGdbRemote*/TestLldbGdbServer.
Fixed intermittent failures in TestGdbRemote*/TestLldbGdbServer
May 21 2015, 11:58 AM
vharron closed D9869: Fixed intermittent failures in TestGdbRemote*/TestLldbGdbServer by committing rL237932: Fixed intermittent failures in TestGdbRemote*/TestLldbGdbServer.
May 21 2015, 11:58 AM
vharron committed rL237931: Re-enable packet logging for GdbRemote/LldbServer tests.
Re-enable packet logging for GdbRemote/LldbServer tests
May 21 2015, 11:55 AM
vharron closed D9847: Re-enable packet logging for GdbRemote/LldbServer tests by committing rL237931: Re-enable packet logging for GdbRemote/LldbServer tests.
May 21 2015, 11:55 AM
vharron added a comment to D9116: [TestChangeValueAPI] Remove expectedFailureGcc decorator..

Please land it if it's still valid.

May 21 2015, 11:45 AM
vharron committed rL237928: Fix lldb executable discovery on OS X.
Fix lldb executable discovery on OS X
May 21 2015, 11:24 AM
vharron closed D9846: Fix lldb executable discovery on OS X by committing rL237928: Fix lldb executable discovery on OS X.
May 21 2015, 11:24 AM
vharron committed rL237926: dotest.py - log session to a file instead of a StringIO class.
dotest.py - log session to a file instead of a StringIO class
May 21 2015, 11:24 AM
vharron closed D9845: log session to a file instead of a StringIO class by committing rL237926: dotest.py - log session to a file instead of a StringIO class.
May 21 2015, 11:24 AM
vharron committed rL237925: Add logging for XTIMEOUT/UnexpectedSuccess.
Add logging for XTIMEOUT/UnexpectedSuccess
May 21 2015, 11:22 AM
vharron closed D9843: Add logging for XTIMEOUT/UnexpectedSuccess by committing rL237925: Add logging for XTIMEOUT/UnexpectedSuccess.
May 21 2015, 11:22 AM
vharron committed rL237923: Modify dosep.py to add default session dir parameter.
Modify dosep.py to add default session dir parameter
May 21 2015, 11:19 AM
vharron closed D9839: Modify dosep.py to add default session dir parameter by committing rL237923: Modify dosep.py to add default session dir parameter.
May 21 2015, 11:19 AM
vharron committed rL237921: TestInlineStepping - made XFAIL more specific.
TestInlineStepping - made XFAIL more specific
May 21 2015, 11:11 AM
vharron closed D9828: XFAIL'd TestInlineStepping.py by committing rL237921: TestInlineStepping - made XFAIL more specific.
May 21 2015, 11:11 AM
vharron added a comment to D9116: [TestChangeValueAPI] Remove expectedFailureGcc decorator..

Is this still open?

May 21 2015, 10:54 AM
vharron added a comment to D9117: [TestBuiltinTrap] Change skipIfGcc to expectedFailure for GCC <= 4.6..

Is this still open?

May 21 2015, 10:53 AM

May 20 2015

vharron retitled D9905: dosep - force timeout processes to dump core when they timeout from to dosep - force timeout processes to dump core when they timeout.
May 20 2015, 11:02 PM
vharron committed rL237878: trivial log print fix.
trivial log print fix
May 20 2015, 11:01 PM
vharron retitled D9892: XPASS a bunch of GdbRemote/LldbGdbServer tests from to XPASS a bunch of GdbRemote/LldbGdbServer tests.
May 20 2015, 1:31 PM

May 19 2015

vharron retitled D9869: Fixed intermittent failures in TestGdbRemote*/TestLldbGdbServer from to Fixed intermittent failures in TestGdbRemote*/TestLldbGdbServer.
May 19 2015, 7:48 PM
vharron retitled D9868: dotest.py - debug feature that helps find dosep races from to dotest.py - debug feature that helps find dosep races.
May 19 2015, 7:47 PM
vharron updated the diff for D9847: Re-enable packet logging for GdbRemote/LldbServer tests.

Only enable lldb-server logs when --channel is set

May 19 2015, 12:47 PM
vharron retitled D9859: Removed XFAIL from TestExitDuringBreak from to Removed XFAIL from TestExitDuringBreak.
May 19 2015, 12:45 PM

May 18 2015

vharron retitled D9847: Re-enable packet logging for GdbRemote/LldbServer tests from to Re-enable packet logging for GdbRemote/LldbServer tests.
May 18 2015, 11:28 PM
vharron retitled D9846: Fix lldb executable discovery on OS X from to Fix lldb executable discovery on OS X.
May 18 2015, 10:37 PM
vharron committed rL237665: dotest - minor doc fix.
dotest - minor doc fix
May 18 2015, 10:14 PM
vharron retitled D9845: log session to a file instead of a StringIO class from to log session to a file instead of a StringIO class.
May 18 2015, 9:49 PM
vharron retitled D9843: Add logging for XTIMEOUT/UnexpectedSuccess from to Add logging for XTIMEOUT/UnexpectedSuccess.
May 18 2015, 6:13 PM
vharron committed rL237632: Make it possible to run dotest on Linux without any parameters.
Make it possible to run dotest on Linux without any parameters
May 18 2015, 4:11 PM
vharron closed D9837: Make it possible to run dotest on Linux without any parameters.

r237632

May 18 2015, 4:11 PM
vharron retitled D9839: Modify dosep.py to add default session dir parameter from to Modify dosep.py to add default session dir parameter.
May 18 2015, 4:09 PM
vharron retitled D9837: Make it possible to run dotest on Linux without any parameters from to Make it possible to run dotest on Linux without any parameters.
May 18 2015, 3:11 PM
vharron added a comment to D9728: Refactor many file functions to use FileSpec over strings..

Only got through ProcessPOSIX, will continue later

May 18 2015, 2:45 PM
vharron added a comment to D9814: XFAIL'd some flakey tests on Darwin.

All of these are actually serious and we need to find a way to fix them. It seems bad to just say "they fail sometimes so lets expected fail them".

May 18 2015, 1:07 PM
vharron committed rL237603: Fixes errors in remote tests.
Fixes errors in remote tests
May 18 2015, 12:48 PM
vharron committed rL237602: Refactored dotest arg parser so that it's accessible from dosep.
Refactored dotest arg parser so that it's accessible from dosep
May 18 2015, 12:44 PM