I run the new Android C/C++/GPU Developer Tools teams at Google.
User Details
User Details
- User Since
- Oct 20 2014, 3:01 PM (268 w, 4 d)
Dec 6 2017
Dec 6 2017
Jul 1 2015
Jul 1 2015
vharron added a comment to D10888: Change executable name to a.out..
Spectacular speech to text failure
vharron added a comment to D10888: Change executable name to a.out..
Does the LoL DB API output a clear and actionable error code if the
filename you are launching is too long? If not please add a test for this
Jun 29 2015
Jun 29 2015
vharron added a comment to D10830: Ignore teardown failure if it's caused by removing missing file or directory.
Maybe we should call teardown from expectedFlakey instead?
vharron added a comment to D10800: Fix [vdso] handling on Android (x86 and aarch64).
You can use the gdb remote get auxv command I think to get libvdso load
address.
vharron added a comment to D10800: Fix [vdso] handling on Android (x86 and aarch64).
If you've fixed vdso handling, shouldn't some i386 tests be marked as passing?
Jun 26 2015
Jun 26 2015
vharron added a comment to D10787: Replace `rm -rf` with more portable implementation..
LGTM
Fixed incorrect application of expectedFlakey
Added expectedFlakey test decorator
vharron closed D10721: Added expectedFlakey test decorator by committing rL240789: Added expectedFlakey test decorator.
Jun 25 2015
Jun 25 2015
vharron updated the diff for D10721: Added expectedFlakey test decorator.
Added expectedFlakeyClang/Gcc, switched a bunch of tests to use new decorator.
Jun 24 2015
Jun 24 2015
vharron retitled D10721: Added expectedFlakey test decorator from to Added expectedFlakey test decorator.
Jun 22 2015
Jun 22 2015
Adding some more flakey tests to the XFAIL list
vharron added a comment to D10583: Adding some more flakey tests to the XFAIL list.
Logs sent directly to Ilia
Jun 19 2015
Jun 19 2015
vharron added a comment to D10509: Don't crash if a member declaration is incomplete.
Ah, if clang-3.6 is on your path try -C clang-3.6 instead of /usr/bin/cc
vharron added a comment to D10509: Don't crash if a member declaration is incomplete.
The test suite appears to be failing because it's failing to find a suitable compiler. Try to
vharron retitled D10583: Adding some more flakey tests to the XFAIL list from to Adding some more flakey tests to the XFAIL list.
vharron added a comment to D10509: Don't crash if a member declaration is incomplete.
Hi Keno,
Jun 17 2015
Jun 17 2015
vharron added a comment to D10527: dosep.py: Add ability to set default test timout based on target.
Do remote tests pass in this time range? If not, maybe you should change
it to use 10 minutes for remote targets.
Jun 1 2015
Jun 1 2015
vharron added a comment to D10085: Add Read Thread to GDBRemoteCommunication.
.
Ewan, has your non-stop mode implementation been tested against gdbserver?
May 31 2015
May 31 2015
vharron requested changes to D10085: Add Read Thread to GDBRemoteCommunication.
.
Hi Ewan,
May 28 2015
May 28 2015
vharron added a comment to D10085: Add Read Thread to GDBRemoteCommunication.
.
Hi Ewan,
May 26 2015
May 26 2015
vharron committed rL238284: www - updated build server URLs.
www - updated build server URLs
Changed Flags::clang_type_resolve_state to unsigned for gcc
238283
test Makefile.rules - pick a more sensible default CC on Linux
dosep - force timeout processes to dump core when they timeout
vharron added inline comments to D9902: Link against installed library when running lldb test with gcc-4.9.2.
May 25 2015
May 25 2015
r238173
vharron added a comment to D9953: Send email notification for failures on lldb android builder.
Sorry, I mean
vharron requested changes to D9953: Send email notification for failures on lldb android builder.
revert files unintentionally checked in
Print port number that lldb-server binds to in platform mode
May 24 2015
May 24 2015
vharron retitled D9965: Print port number that lldb-server binds to in platform mode from to Print port number that lldb-server binds to in platform mode.
vharron added a comment to D9884: Remove log2 dependency when building against Android API-9 SDK.
I needed this patch so I was able to verify and submit. Thanks Pierre-Andre!
Remove log2 dependency when building against Android API-9 SDK
May 23 2015
May 23 2015
vharron added a comment to D9950: Changed ResolveState to unsigned to work around noisy gcc warning.
I will change this to only use "unsigned" type when compiled with gcc.
May 22 2015
May 22 2015
vharron retitled D9950: Changed ResolveState to unsigned to work around noisy gcc warning from to Changed ResolveState to unsigned to work around noisy gcc warning.
vharron added a comment to D9948: [TestBase.runCmd] Better error message when runCmd fails..
I removed my approval, waiting for feedback from others.
vharron removed a reviewer for D9948: [TestBase.runCmd] Better error message when runCmd fails.: vharron.
vharron added a reviewer for D9948: [TestBase.runCmd] Better error message when runCmd fails.: vharron.
dotest.py - fixed a bug displaying usage
vharron retitled D9937: dotest.py - fixed a bug displaying usage from to dotest.py - fixed a bug displaying usage.
May 21 2015
May 21 2015
vharron updated the diff for D9920: test Makefile.rules - pick a more sensible default CC on Linux.
Removed Makefile
vharron retitled D9920: test Makefile.rules - pick a more sensible default CC on Linux from to test Makefile.rules - pick a more sensible default CC on Linux.
vharron added a comment to D9868: dotest.py - debug feature that helps find dosep races.
I'll add a command line parameter in a followup CL (when we suspect this is a problem again)
dotest.py - debug feature that helps find dosep races
XPASS a bunch of GdbRemote/LldbGdbServer tests
Fixed intermittent failures in TestGdbRemote*/TestLldbGdbServer
Re-enable packet logging for GdbRemote/LldbServer tests
vharron added a comment to D9116: [TestChangeValueAPI] Remove expectedFailureGcc decorator..
Please land it if it's still valid.
Fix lldb executable discovery on OS X
dotest.py - log session to a file instead of a StringIO class
Add logging for XTIMEOUT/UnexpectedSuccess
Modify dosep.py to add default session dir parameter
TestInlineStepping - made XFAIL more specific
vharron added a comment to D9116: [TestChangeValueAPI] Remove expectedFailureGcc decorator..
Is this still open?
vharron added a comment to D9117: [TestBuiltinTrap] Change skipIfGcc to expectedFailure for GCC <= 4.6..
Is this still open?
May 20 2015
May 20 2015
vharron retitled D9905: dosep - force timeout processes to dump core when they timeout from to dosep - force timeout processes to dump core when they timeout.
vharron retitled D9892: XPASS a bunch of GdbRemote/LldbGdbServer tests from to XPASS a bunch of GdbRemote/LldbGdbServer tests.
May 19 2015
May 19 2015
vharron retitled D9869: Fixed intermittent failures in TestGdbRemote*/TestLldbGdbServer from to Fixed intermittent failures in TestGdbRemote*/TestLldbGdbServer.
vharron retitled D9868: dotest.py - debug feature that helps find dosep races from to dotest.py - debug feature that helps find dosep races.
vharron updated the diff for D9847: Re-enable packet logging for GdbRemote/LldbServer tests.
Only enable lldb-server logs when --channel is set
vharron retitled D9859: Removed XFAIL from TestExitDuringBreak from to Removed XFAIL from TestExitDuringBreak.
May 18 2015
May 18 2015
vharron retitled D9847: Re-enable packet logging for GdbRemote/LldbServer tests from to Re-enable packet logging for GdbRemote/LldbServer tests.
vharron retitled D9846: Fix lldb executable discovery on OS X from to Fix lldb executable discovery on OS X.
vharron retitled D9845: log session to a file instead of a StringIO class from to log session to a file instead of a StringIO class.
vharron retitled D9843: Add logging for XTIMEOUT/UnexpectedSuccess from to Add logging for XTIMEOUT/UnexpectedSuccess.
Make it possible to run dotest on Linux without any parameters
r237632
vharron retitled D9839: Modify dosep.py to add default session dir parameter from to Modify dosep.py to add default session dir parameter.
vharron retitled D9837: Make it possible to run dotest on Linux without any parameters from to Make it possible to run dotest on Linux without any parameters.
vharron added a comment to D9728: Refactor many file functions to use FileSpec over strings..
Only got through ProcessPOSIX, will continue later
vharron added a comment to D9814: XFAIL'd some flakey tests on Darwin.
All of these are actually serious and we need to find a way to fix them. It seems bad to just say "they fail sometimes so lets expected fail them".
vharron committed rL237603: Fixes errors in remote tests.
Fixes errors in remote tests
Refactored dotest arg parser so that it's accessible from dosep