This is an archive of the discontinued LLVM Phabricator instance.

[libclang] Remove duplicate dependency on LLVMSupport
ClosedPublic

Authored by jkorous on May 5 2020, 3:44 PM.

Reviewers

Commits

Summary

jkorous marked an inline comment as done.May 5 2020, 3:45 PM

jkorous added inline comments.

clang/tools/libclang/CMakeLists.txt
116	This is the original dependency.

Thanks for the fast response! lgtm

This revision is now accepted and ready to land.May 5 2020, 4:46 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang/

tools/

libclang/

1 line

Show All 38 Lines	set(LIBS
clangBasic		clangBasic
clangDriver		clangDriver
clangFrontend		clangFrontend
clangIndex		clangIndex
clangLex		clangLex
clangSema		clangSema
clangSerialization		clangSerialization
clangTooling		clangTooling
LLVMSupport
)		)

if (CLANG_ENABLE_ARCMT)		if (CLANG_ENABLE_ARCMT)
list(APPEND LIBS clangARCMigrate)		list(APPEND LIBS clangARCMigrate)
endif ()		endif ()

if (TARGET clangTidyPlugin)		if (TARGET clangTidyPlugin)
add_definitions(-DCLANG_TOOL_EXTRA_BUILD)		add_definitions(-DCLANG_TOOL_EXTRA_BUILD)
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines	add_clang_library(libclang ${ENABLE_SHARED} ${ENABLE_STATIC} INSTALL_WITH_TOOLCHAIN
clang-resource-headers		clang-resource-headers

LINK_LIBS		LINK_LIBS
${LIBS}		${LIBS}

LINK_COMPONENTS		LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD}		${LLVM_TARGETS_TO_BUILD}
Core		Core
Support		Support
		jkorousAuthorUnsubmitted Done Reply Inline Actions This is the original dependency. jkorous: This is the original dependency.
)		)

if(ENABLE_STATIC)		if(ENABLE_STATIC)
foreach(name libclang obj.libclang libclang_static)		foreach(name libclang obj.libclang libclang_static)
if (TARGET ${name})		if (TARGET ${name})
target_compile_definitions(${name} PUBLIC CINDEX_NO_EXPORTS)		target_compile_definitions(${name} PUBLIC CINDEX_NO_EXPORTS)
endif()		endif()
endforeach()		endforeach()
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines