Page MenuHomePhabricator

[clang][codegen] Refactor argument loading in function prolog. NFC.
ClosedPublic

Authored by hliao on Mon, May 4, 10:42 PM.

Details

Summary
  • Skip copying function arguments and unnecessary casting by using them directly.

Diff Detail

Event Timeline

hliao created this revision.Mon, May 4, 10:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, May 4, 10:42 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rjmccall accepted this revision.Tue, May 5, 10:42 AM

Oh, yes, if Fn->getArg(n) is no longer an O(n) linked-list walk, then this seems like a great change. I see that that happened... slightly over three years ago. Hooray for legacies. LGTM.

This revision is now accepted and ready to land.Tue, May 5, 10:42 AM
This revision was automatically updated to reflect the committed changes.