Page MenuHomePhabricator

[SanitizerCoverage] Replace the unconditional store with a load, then a conditional store.
ClosedPublic

Authored by pratyai on May 4 2020, 9:17 PM.

Diff Detail

Event Timeline

pratyai created this revision.May 4 2020, 9:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2020, 9:17 PM
vitalybuka accepted this revision.May 5 2020, 1:23 AM
vitalybuka added inline comments.
llvm/test/Instrumentation/SanitizerCoverage/inline-bool-flag.ll
4

you can use env var for that
FILECHECK_OPTS="--dump-input=fail" ninja check-all

This revision is now accepted and ready to land.May 5 2020, 1:23 AM
vitalybuka added inline comments.May 5 2020, 1:38 AM
llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
951

This should be the opposite?
I'll fix this.

vitalybuka added inline comments.May 5 2020, 1:40 AM
llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
951

Now:

if (Load) {
  Store
}

should be :

if (!Load) {
  Store
}
pratyai marked an inline comment as done.May 5 2020, 2:16 AM
pratyai added inline comments.
llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
951

My bad; fixing.

vitalybuka updated this revision to Diff 262038.May 5 2020, 2:22 AM

fix branch

pratyai updated this revision to Diff 262037.May 5 2020, 2:23 AM
pratyai updated this revision to Diff 262039.May 5 2020, 2:25 AM

fix branch

Oops; sorry; didn't notice your updates :(

This revision was automatically updated to reflect the committed changes.