This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Rename *ByValOrInalloca* to *PassPointeeByValue*
ClosedPublic

Authored by aeubanks on Apr 29 2020, 6:53 PM.

Details

Summary

In preparation for preallocated.

Diff Detail

Event Timeline

aeubanks created this revision.Apr 29 2020, 6:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2020, 6:53 PM

If this is too much abstraction then we can inline it everywhere. I'm not a fan of these functions as is.

rnk accepted this revision.Apr 30 2020, 6:57 AM

Naming looks good, please commit after updating the two doc comments.

llvm/include/llvm/IR/Argument.h
74–75

Since the preallocated attribute exists now, please update this to include it.

llvm/include/llvm/IR/InstrTypes.h
1544

Also needs a tweak

This revision is now accepted and ready to land.Apr 30 2020, 6:57 AM

I was planning on adding preallocated in a later patch, but now is fine too :)

This revision was automatically updated to reflect the committed changes.