This is an archive of the discontinued LLVM Phabricator instance.

Differential D79128

Make wrong preallocated arg count verifier error clearer
ClosedPublic

Authored by aeubanks on Apr 29 2020, 1:53 PM.

Details

Reviewers
rnk
Commits
rG52ec98389543: Make wrong preallocated arg count verifier error clearer

Diff Detail

Event Timeline

aeubanks created this revision.Apr 29 2020, 1:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2020, 1:53 PM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
aeubanks retitled this revision from Make wrong arg count verifier error clearer to Make wrong preallocated arg count verifier error clearer.Apr 29 2020, 1:54 PM
Harbormaster completed remote builds in B55180: Diff 261022.Apr 29 2020, 2:33 PM
rnk accepted this revision.Apr 29 2020, 2:37 PM

lgtm

This revision is now accepted and ready to land.Apr 29 2020, 2:37 PM
Closed by commit rG52ec98389543: Make wrong preallocated arg count verifier error clearer (authored by aeubanks). · Explain WhyApr 29 2020, 6:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
IR/
5 lines
test/
Verifier/
2 lines

Diff 261022

llvm/lib/IR/Verifier.cpp

Show First 20 Lines • Show All 4,501 Lines • ▼ Show 20 Lines for (User *U : Call.users()) {
size_t NumPreallocatedArgs = 0; size_t NumPreallocatedArgs = 0;
for (auto &Arg : Fn->args()) { for (auto &Arg : Fn->args()) {
if (Arg.hasAttribute(Attribute::Preallocated)) { if (Arg.hasAttribute(Attribute::Preallocated)) {
++NumPreallocatedArgs; ++NumPreallocatedArgs;
} }
} }
Assert(NumArgs->equalsInt(NumPreallocatedArgs), Assert(NumArgs->equalsInt(NumPreallocatedArgs),
"llvm.call.preallocated.setup arg size must be equal to number " "llvm.call.preallocated.setup arg size must be equal to number "
"of arguments " "of preallocated arguments "
"at call site"); "at call site",
Call, *UseCall);
// getOperandBundle() cannot be called if more than one of the operand // getOperandBundle() cannot be called if more than one of the operand
// bundle exists. There is already a check elsewhere for this, so skip // bundle exists. There is already a check elsewhere for this, so skip
// here if we see more than one. // here if we see more than one.
if (UseCall->countOperandBundlesOfType(LLVMContext::OB_preallocated) > if (UseCall->countOperandBundlesOfType(LLVMContext::OB_preallocated) >
1) { 1) {
return; return;
} }
auto PreallocatedBundle = auto PreallocatedBundle =
▲ Show 20 Lines • Show All 1,233 Lines • Show Last 20 Lines

llvm/test/Verifier/preallocated-invalid.ll

Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
define void @preallocated_require_bundle() { define void @preallocated_require_bundle() {
%cs = call token @llvm.call.preallocated.setup(i32 1) %cs = call token @llvm.call.preallocated.setup(i32 1)
%x = call i8* @llvm.call.preallocated.arg(token %cs, i32 0) preallocated(i32) %x = call i8* @llvm.call.preallocated.arg(token %cs, i32 0) preallocated(i32)
%y = bitcast i8* %x to i32* %y = bitcast i8* %x to i32*
call void @foo1(i32* preallocated(i32) %y) call void @foo1(i32* preallocated(i32) %y)
ret void ret void
} }
; CHECK: arg size must be equal to number of arguments ; CHECK: arg size must be equal to number of preallocated arguments
define void @preallocated_num_args() { define void @preallocated_num_args() {
%cs = call token @llvm.call.preallocated.setup(i32 3) %cs = call token @llvm.call.preallocated.setup(i32 3)
%x = call i8* @llvm.call.preallocated.arg(token %cs, i32 0) preallocated(i32) %x = call i8* @llvm.call.preallocated.arg(token %cs, i32 0) preallocated(i32)
%x1 = bitcast i8* %x to i32* %x1 = bitcast i8* %x to i32*
%y = call i8* @llvm.call.preallocated.arg(token %cs, i32 1) preallocated(i32) %y = call i8* @llvm.call.preallocated.arg(token %cs, i32 1) preallocated(i32)
%y1 = bitcast i8* %y to i32* %y1 = bitcast i8* %y to i32*
%a = inttoptr i32 0 to i32* %a = inttoptr i32 0 to i32*
call void @foo2(i32* preallocated(i32) %x1, i32* %a, i32* preallocated(i32) %y1) ["preallocated"(token %cs)] call void @foo2(i32* preallocated(i32) %x1, i32* %a, i32* preallocated(i32) %y1) ["preallocated"(token %cs)]
Show All 9 Lines