This is an archive of the discontinued LLVM Phabricator instance.

[lldb/API] Move SBCommandInterpreterRunOption in its own header. (NFC)
ClosedPublic

Authored by JDevlieghere on Apr 29 2020, 12:20 PM.

Details

Summary

Currently, SBCommandInterpreterRunOptions is defined in SBCommandInterpreter.h. Given that the options are always passed by value, a forward declaration of the class as sufficient. That's not the case SBCommandInterpreterRunResults if we want to add a new overload SBCommandInterpreterRunResults RunCommandInterpreter(const SBCommandInterpreterRunOptions &options);.. We can't include SBCommandInterpreter.h because SBCommandInterpreter::GetDebugger() returns SBDebugger by value and therefore needs a full definition.

My plan is to have both SBCommandInterpreterRunOptions and SBCommandInterpreterRunResults defined in this file.

Diff Detail